mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH-rt] genirq error message clarification
@ 2006-06-10 21:43 Deepak Saxena
  2006-06-10 21:45 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: Deepak Saxena @ 2006-06-10 21:43 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Ingo Molnar, linux-kernel


It makes it a bit easier to debug issues when we know what irq we're
having problems with.

Signed-off-by: Deepak Saxena <dsaxena@plexity.net>


Index: linux-2.6-rt/kernel/irq/manage.c
===================================================================
--- linux-2.6-rt.orig/kernel/irq/manage.c
+++ linux-2.6-rt/kernel/irq/manage.c
@@ -328,7 +328,8 @@ int setup_irq(unsigned int irq, struct i
 mismatch:
 	spin_unlock_irqrestore(&desc->lock, flags);
 	if (!(new->flags & SA_PROBEIRQ)) {
-		printk(KERN_ERR "%s: irq handler mismatch\n", __FUNCTION__);
+		printk(KERN_ERR "%s: irq %d handler mismatch\n", __FUNCTION__,
+				irq);
 		dump_stack();
 	}
 	return -EBUSY;

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertold Brecht

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH-rt] genirq error message clarification
  2006-06-10 21:43 [PATCH-rt] genirq error message clarification Deepak Saxena
@ 2006-06-10 21:45 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2006-06-10 21:45 UTC (permalink / raw)
  To: dsaxena; +Cc: Ingo Molnar, linux-kernel

On Sat, 2006-06-10 at 14:43 -0700, Deepak Saxena wrote:
> It makes it a bit easier to debug issues when we know what irq we're
> having problems with.
> 
> Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
> 
> 
> Index: linux-2.6-rt/kernel/irq/manage.c
> ===================================================================
> --- linux-2.6-rt.orig/kernel/irq/manage.c
> +++ linux-2.6-rt/kernel/irq/manage.c
> @@ -328,7 +328,8 @@ int setup_irq(unsigned int irq, struct i
>  mismatch:
>  	spin_unlock_irqrestore(&desc->lock, flags);
>  	if (!(new->flags & SA_PROBEIRQ)) {
> -		printk(KERN_ERR "%s: irq handler mismatch\n", __FUNCTION__);
> +		printk(KERN_ERR "%s: irq %d handler mismatch\n", __FUNCTION__,
> +				irq);
>  		dump_stack();
>  	}
>  	return -EBUSY;

Makes sense. Thanks, applied

	tglx






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-10 21:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-10 21:43 [PATCH-rt] genirq error message clarification Deepak Saxena
2006-06-10 21:45 ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®