From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Greg KH <greg@kroah.com>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Clean up old names in tty code to current names
Date: Mon, 10 Jul 2006 15:37:29 +0100 [thread overview]
Message-ID: <1152542249.27368.128.camel@localhost.localdomain> (raw)
In-Reply-To: <9e4733910607100707g4810a86boa93a5b6b0b1a8d0a@mail.gmail.com>
Ar Llu, 2006-07-10 am 10:07 -0400, ysgrifennodd Jon Smirl:
> The ttyp change was a mistake. The patch below removes that error. Is
> there anything else wrong with it? That's why we have patch reviews,
> to catch dumb errors like that.
Its change for no purpose. It doesn't "fix" anything and it might well
break stuff like installers. Put the new "correct" data in the new sysfs
stuff you talk about.
Alan
next prev parent reply other threads:[~2006-07-10 14:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 4:11 Jon Smirl
2006-07-10 4:54 ` Andrew Morton
2006-07-10 7:14 ` H. Peter Anvin
2006-07-10 9:44 ` Alan Cox
2006-07-10 12:41 ` Jon Smirl
2006-07-10 13:10 ` Alan Cox
2006-07-10 13:03 ` Jon Smirl
2006-07-10 13:12 ` CaT
2006-07-10 13:18 ` Jon Smirl
2006-07-10 13:43 ` Alan Cox
2006-07-10 14:07 ` Jon Smirl
2006-07-10 14:17 ` Jan Engelhardt
2006-07-10 14:37 ` Alan Cox [this message]
2006-07-10 14:42 ` Antonino A. Daplas
2006-07-10 14:57 ` Jon Smirl
2006-07-10 15:19 ` Alan Cox
2006-07-10 15:10 ` Valdis.Kletnieks
2006-07-10 15:21 ` Russell King
2006-07-10 15:38 ` Valdis.Kletnieks
2006-07-10 15:35 ` Antonino A. Daplas
2006-07-10 15:54 ` Jon Smirl
2006-07-10 16:04 ` H. Peter Anvin
2006-07-10 22:14 ` Jan Engelhardt
2006-07-10 18:13 ` Alistair John Strachan
2006-07-11 21:54 ` Greg KH
2006-07-11 21:52 ` Greg KH
2006-07-11 2:18 Albert Cahalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152542249.27368.128.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome