* [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer
@ 2006-09-09 15:37 Michael De Backer
2006-09-09 16:15 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Michael De Backer @ 2006-09-09 15:37 UTC (permalink / raw)
To: linux-kernel; +Cc: trivial, akpm
From: Michael De Backer <micdb@skynet.be>
Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).
Signed-off-by: Michael De Backer <micdb@skynet.be>
---
This has been tested on ASUS A8R32-MVP motherboard (M5229 c8) with
2.6.18-rc6, 2.6.18-rc6-mm1, 2.6.18-rc5-mm1, 2.6.17.10 and two different
cd-writers. It completely solves the problem.
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:
--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1
if(m5229_revision <= 0x20)
tmpbyte = (tmpbyte & (~0x02)) | 0x01;
- else if (m5229_revision == 0xc7)
+ else if (m5229_revision == 0xc7 || 0xc8)
tmpbyte |= 0x03;
else
tmpbyte |= 0x01;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer
2006-09-09 15:37 [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer Michael De Backer
@ 2006-09-09 16:15 ` Alan Cox
2006-09-09 19:12 ` Michael De Backer
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2006-09-09 16:15 UTC (permalink / raw)
To: Michael De Backer; +Cc: linux-kernel, trivial, akpm
Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> - else if (m5229_revision == 0xc7)
> + else if (m5229_revision == 0xc7 || 0xc8)
I don't think that is what you mean..
NAK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer
2006-09-09 16:15 ` Alan Cox
@ 2006-09-09 19:12 ` Michael De Backer
2006-09-10 0:35 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Michael De Backer @ 2006-09-09 19:12 UTC (permalink / raw)
To: linux-kernel
Le samedi 09 septembre 2006 à 17:15 +0100, Alan Cox a écrit :
> Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> > - else if (m5229_revision == 0xc7)
> > + else if (m5229_revision == 0xc7 || 0xc8)
>
> I don't think that is what you mean..
>
> NAK
Indeed, let's try again (please forgive my dumbness).
Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).
Signed-off-by: Michael De Backer <micdb@skynet.be>
---
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:
--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1
if(m5229_revision <= 0x20)
tmpbyte = (tmpbyte & (~0x02)) | 0x01;
- else if (m5229_revision == 0xc7)
+ else if (m5229_revision == 0xc7 || m5229_revision == 0xc8)
tmpbyte |= 0x03;
else
tmpbyte |= 0x01;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer
2006-09-09 19:12 ` Michael De Backer
@ 2006-09-10 0:35 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2006-09-10 0:35 UTC (permalink / raw)
To: Michael De Backer; +Cc: linux-kernel
Ar Sad, 2006-09-09 am 21:12 +0200, ysgrifennodd Michael De Backer:
> > I don't think that is what you mean..
> >
> > NAK
> Indeed, let's try again (please forgive my dumbness).
I've just put at least a dumb a mistake in 2.6.18 final so I wouldnt
worry - we all do it.
> Configuration bits are not set properly for DMA on some chipset
> revisions. It has already been corrected for M5229 (rev c7) but not for
> M5229 (rev c8). This leads to the bug described at
> http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
> bus hangs).
>
> Signed-off-by: Michael De Backer <micdb@skynet.be>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-09-10 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-09-09 15:37 [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer Michael De Backer
2006-09-09 16:15 ` Alan Cox
2006-09-09 19:12 ` Michael De Backer
2006-09-10 0:35 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome