mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [GIT] Linux client patches against Linux 2.6.18
       [not found] <1158982165.5493.12.camel@lade.trondhjem.org>
@ 2006-09-24  0:06 ` Linus Torvalds
  2006-09-24  6:37   ` Trond Myklebust
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Torvalds @ 2006-09-24  0:06 UTC (permalink / raw)
  To: Trond Myklebust; +Cc: Andrew Morton, linux-kernel



On Fri, 22 Sep 2006, Trond Myklebust wrote:
> 
>    git pull git://git.linux-nfs.org/pub/linux/nfs-2.6.git

I'm not entirely happy with this.

Why were the generic VFS layer patches wrapped up in this big thing, 
instead of being sent separately with the proper people looking at them?

I'm not seeing a sign-off or ack for the dentry stuff from Al, for 
example. Was it passed by him? You moved the dentry rehash function inside 
the dcache_lock, and if that was a bug-fix, it should have been marked as 
so and done separately etc.

In other words, this was _not_ the right way to merge these things. I'm a 
bit grumpy.

		Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT] Linux client patches against Linux 2.6.18
  2006-09-24  0:06 ` [GIT] Linux client patches against Linux 2.6.18 Linus Torvalds
@ 2006-09-24  6:37   ` Trond Myklebust
  0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2006-09-24  6:37 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Andrew Morton, linux-kernel

On Sat, 2006-09-23 at 17:06 -0700, Linus Torvalds wrote:

> I'm not seeing a sign-off or ack for the dentry stuff from Al, for 
> example. Was it passed by him? You moved the dentry rehash function inside 
> the dcache_lock, and if that was a bug-fix, it should have been marked as 
> so and done separately etc.

The only function that was moved inside the spinlock was d_hash(), but
that is a fairly trivial change (d_revalidate already does the same).
Otherwise, the only effect of the changes was to create unlocked
versions of d_rehash() for reuse in the new d_materialise_dentry().

In any case, all of those patches have been presented by David on the
fs-devel and lkml lists several times. The last time would be on 27th
July:

 http://marc.theaimsgroup.com/?l=linux-kernel&m=115403487316197&w=2

Al has in addition been Cced on much of the correspondence between David
and myself during the preparation for merging (although that would be
almost half a year ago now).
Finally, Christoph was also pressed into duty as an extra reviewer.

So yes, afaik all the relevant people have been kept informed, even if
they were not labelled as having been Cced in the changelog.

So I apologize for not having sent this as a separate patch, but as I
said above, it was a trivial change as far as the rehash is concerned,
and the only user of the new function is NFS.

Cheers,
  Trond


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-24  6:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1158982165.5493.12.camel@lade.trondhjem.org>
2006-09-24  0:06 ` [GIT] Linux client patches against Linux 2.6.18 Linus Torvalds
2006-09-24  6:37   ` Trond Myklebust

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®