* [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
@ 2006-10-10 11:17 Robert P. J. Day
2006-10-10 11:31 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2006-10-10 11:17 UTC (permalink / raw)
To: Linux kernel mailing list; +Cc: trivial
Simplify the definition of IXGB_DBG() to be based on pr_debug().
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
index 50ffe90..16e6c3d 100644
--- a/drivers/net/ixgb/ixgb.h
+++ b/drivers/net/ixgb/ixgb.h
@@ -77,11 +77,7 @@ #include "ixgb_hw.h"
#include "ixgb_ee.h"
#include "ixgb_ids.h"
-#ifdef _DEBUG_DRIVER_
-#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
-#else
-#define IXGB_DBG(args...)
-#endif
+#define IXGB_DBG(args...) pr_debug("ixgb: ", args)
#define PFX "ixgb: "
#define DPRINTK(nlevel, klevel, fmt, args...) \
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
2006-10-10 11:17 [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug() Robert P. J. Day
@ 2006-10-10 11:31 ` Arjan van de Ven
2006-10-10 11:35 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Arjan van de Ven @ 2006-10-10 11:31 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list, trivial
On Tue, 2006-10-10 at 07:17 -0400, Robert P. J. Day wrote:
> Simplify the definition of IXGB_DBG() to be based on pr_debug().
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> ---
> diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> index 50ffe90..16e6c3d 100644
> --- a/drivers/net/ixgb/ixgb.h
> +++ b/drivers/net/ixgb/ixgb.h
> @@ -77,11 +77,7 @@ #include "ixgb_hw.h"
> #include "ixgb_ee.h"
> #include "ixgb_ids.h"
>
> -#ifdef _DEBUG_DRIVER_
> -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> -#else
> -#define IXGB_DBG(args...)
> -#endif
> +#define IXGB_DBG(args...) pr_debug("ixgb: ", args)
while this is of course correct, why not go all the way and replace all
IXGB() users to pr_debug() directly?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug().
2006-10-10 11:31 ` Arjan van de Ven
@ 2006-10-10 11:35 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2006-10-10 11:35 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Linux kernel mailing list, trivial
On Tue, 10 Oct 2006, Arjan van de Ven wrote:
> On Tue, 2006-10-10 at 07:17 -0400, Robert P. J. Day wrote:
> > Simplify the definition of IXGB_DBG() to be based on pr_debug().
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > ---
> > diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> > index 50ffe90..16e6c3d 100644
> > --- a/drivers/net/ixgb/ixgb.h
> > +++ b/drivers/net/ixgb/ixgb.h
> > @@ -77,11 +77,7 @@ #include "ixgb_hw.h"
> > #include "ixgb_ee.h"
> > #include "ixgb_ids.h"
> >
> > -#ifdef _DEBUG_DRIVER_
> > -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> > -#else
> > -#define IXGB_DBG(args...)
> > -#endif
> > +#define IXGB_DBG(args...) pr_debug("ixgb: ", args)
>
>
> while this is of course correct, why not go all the way and replace all
> IXGB() users to pr_debug() directly?
fair enough, i can do that. back later.
rday
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-10 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-10 11:17 [PATCH] ixgb.h: Redefine IXGB_DBG() macro to use pr_debug() Robert P. J. Day
2006-10-10 11:31 ` Arjan van de Ven
2006-10-10 11:35 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®