* [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG".
@ 2007-02-02 10:46 Robert P. J. Day
2007-02-02 11:10 ` Anton Altaparmakov
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2007-02-02 10:46 UTC (permalink / raw)
To: Linux kernel mailing list; +Cc: Andrew Morton, aia21
Replace the apparently incorrect macro name "NTFS_DEBUG" with
"CONFIG_NTFS_DEBUG".
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index c577d8e..2154d03 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
@@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
u32 attr_len = 0; /* Silence stupid gcc warning. */
bool mp_rebuilt;
-#ifdef NTFS_DEBUG
+#ifdef CONFIG_NTFS_DEBUG
read_lock_irqsave(&ni->size_lock, flags);
allocated_size = ni->allocated_size;
read_unlock_irqrestore(&ni->size_lock, flags);
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG".
2007-02-02 10:46 [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG" Robert P. J. Day
@ 2007-02-02 11:10 ` Anton Altaparmakov
2007-02-02 11:14 ` Anton Altaparmakov
2007-02-02 11:22 ` Robert P. J. Day
0 siblings, 2 replies; 4+ messages in thread
From: Anton Altaparmakov @ 2007-02-02 11:10 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list, Andrew Morton, aia21
Hi,
On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> Replace the apparently incorrect macro name "NTFS_DEBUG" with
> "CONFIG_NTFS_DEBUG".
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index c577d8e..2154d03 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
> u32 attr_len = 0; /* Silence stupid gcc warning. */
> bool mp_rebuilt;
>
> -#ifdef NTFS_DEBUG
> +#ifdef CONFIG_NTFS_DEBUG
The fix is also wrong. It should be:
#ifdef DEBUG
See fs/ntfs/Makefile for details...
> read_lock_irqsave(&ni->size_lock, flags);
> allocated_size = ni->allocated_size;
> read_unlock_irqrestore(&ni->size_lock, flags);
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG".
2007-02-02 11:10 ` Anton Altaparmakov
@ 2007-02-02 11:14 ` Anton Altaparmakov
2007-02-02 11:22 ` Robert P. J. Day
1 sibling, 0 replies; 4+ messages in thread
From: Anton Altaparmakov @ 2007-02-02 11:14 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux kernel mailing list, Andrew Morton, aia21
Forgot to say the most important bit: Thanks for the catch! (-:
Best regards,
Anton
On Fri, 2007-02-02 at 11:10 +0000, Anton Altaparmakov wrote:
> Hi,
>
> On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> > Replace the apparently incorrect macro name "NTFS_DEBUG" with
> > "CONFIG_NTFS_DEBUG".
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
> >
> > diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> > index c577d8e..2154d03 100644
> > --- a/fs/ntfs/attrib.c
> > +++ b/fs/ntfs/attrib.c
> > @@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
> > u32 attr_len = 0; /* Silence stupid gcc warning. */
> > bool mp_rebuilt;
> >
> > -#ifdef NTFS_DEBUG
> > +#ifdef CONFIG_NTFS_DEBUG
>
> The fix is also wrong. It should be:
>
> #ifdef DEBUG
>
> See fs/ntfs/Makefile for details...
>
> > read_lock_irqsave(&ni->size_lock, flags);
> > allocated_size = ni->allocated_size;
> > read_unlock_irqrestore(&ni->size_lock, flags);
>
> Best regards,
>
> Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG".
2007-02-02 11:10 ` Anton Altaparmakov
2007-02-02 11:14 ` Anton Altaparmakov
@ 2007-02-02 11:22 ` Robert P. J. Day
1 sibling, 0 replies; 4+ messages in thread
From: Robert P. J. Day @ 2007-02-02 11:22 UTC (permalink / raw)
To: Anton Altaparmakov; +Cc: Linux kernel mailing list, Andrew Morton, aia21
On Fri, 2 Feb 2007, Anton Altaparmakov wrote:
> Hi,
>
> On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> > Replace the apparently incorrect macro name "NTFS_DEBUG" with
> > "CONFIG_NTFS_DEBUG".
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
> >
> > diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> > index c577d8e..2154d03 100644
> > --- a/fs/ntfs/attrib.c
> > +++ b/fs/ntfs/attrib.c
> > @@ -1921,7 +1921,7 @@ s64 ntfs_attr_extend_allocation(ntfs_inode *ni, s64 new_alloc_size,
> > u32 attr_len = 0; /* Silence stupid gcc warning. */
> > bool mp_rebuilt;
> >
> > -#ifdef NTFS_DEBUG
> > +#ifdef CONFIG_NTFS_DEBUG
>
> The fix is also wrong. It should be:
>
> #ifdef DEBUG
>
> See fs/ntfs/Makefile for details...
ah, yes, i see what you mean. revised patch coming shortly, i'll send
that one to just the relevant parties.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-02-02 12:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-02 10:46 [PATCH] NTFS: Rename apparently incorrect macro name "NTFS_DEBUG" Robert P. J. Day
2007-02-02 11:10 ` Anton Altaparmakov
2007-02-02 11:14 ` Anton Altaparmakov
2007-02-02 11:22 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®