* [PATCH] Fix UCB1x00 driver to use sched_setscheduler
@ 2007-05-11 10:39 Satoru Takeuchi
2007-05-11 11:32 ` Pavel Machek
2007-05-12 13:10 ` Thomas Gleixner
0 siblings, 2 replies; 5+ messages in thread
From: Satoru Takeuchi @ 2007-05-11 10:39 UTC (permalink / raw)
To: Linux Kernel, Russell King, Pavel Machek, Jordi Colomer; +Cc: Satoru Takeuchi
Fix Touchscreen driver for UCB1x00-based touchscreens to use
sched_setscheduler() instead of setting the fields of task_struct directly.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
===================================================================
--- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
+++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
@@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
* We could run as a real-time thread. However, thus far
* this doesn't seem to be necessary.
*/
-// tsk->policy = SCHED_FIFO;
-// tsk->rt_priority = 1;
+// struct sched_param param = { .sched_priority = 1 };
+//
+// sched_setscheduler(tsk, SCHED_FIFO, ¶m);
valid = 0;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
2007-05-11 10:39 [PATCH] Fix UCB1x00 driver to use sched_setscheduler Satoru Takeuchi
@ 2007-05-11 11:32 ` Pavel Machek
2007-05-12 13:10 ` Thomas Gleixner
1 sibling, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2007-05-11 11:32 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: Linux Kernel, Russell King, Jordi Colomer
Hi!
> Fix Touchscreen driver for UCB1x00-based touchscreens to use
> sched_setscheduler() instead of setting the fields of task_struct directly.
>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Looks ok to me.
Pavel
> Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> ===================================================================
> --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
> +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
> @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> * We could run as a real-time thread. However, thus far
> * this doesn't seem to be necessary.
> */
> -// tsk->policy = SCHED_FIFO;
> -// tsk->rt_priority = 1;
> +// struct sched_param param = { .sched_priority = 1 };
> +//
> +// sched_setscheduler(tsk, SCHED_FIFO, ¶m);
>
> valid = 0;
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
2007-05-11 10:39 [PATCH] Fix UCB1x00 driver to use sched_setscheduler Satoru Takeuchi
2007-05-11 11:32 ` Pavel Machek
@ 2007-05-12 13:10 ` Thomas Gleixner
2007-05-13 23:56 ` Satoru Takeuchi
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Gleixner @ 2007-05-12 13:10 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: Linux Kernel, Russell King, Pavel Machek, Jordi Colomer
On Fri, 2007-05-11 at 19:39 +0900, Satoru Takeuchi wrote:
> Fix Touchscreen driver for UCB1x00-based touchscreens to use
> sched_setscheduler() instead of setting the fields of task_struct directly.
>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>
> Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> ===================================================================
> --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
> +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
> @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> * We could run as a real-time thread. However, thus far
> * this doesn't seem to be necessary.
> */
> -// tsk->policy = SCHED_FIFO;
> -// tsk->rt_priority = 1;
> +// struct sched_param param = { .sched_priority = 1 };
> +//
> +// sched_setscheduler(tsk, SCHED_FIFO, ¶m);
Can we please remove the unused code completely instead of replacing it
by more commented out code ?
tglx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
2007-05-12 13:10 ` Thomas Gleixner
@ 2007-05-13 23:56 ` Satoru Takeuchi
2007-05-14 9:21 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: Satoru Takeuchi @ 2007-05-13 23:56 UTC (permalink / raw)
To: tglx; +Cc: Satoru Takeuchi, Linux Kernel, Russell King, Pavel Machek
At Sat, 12 May 2007 15:10:27 +0200,
Thomas Gleixner wrote:
>
> On Fri, 2007-05-11 at 19:39 +0900, Satoru Takeuchi wrote:
> > Fix Touchscreen driver for UCB1x00-based touchscreens to use
> > sched_setscheduler() instead of setting the fields of task_struct directly.
> >
> > Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> >
> > Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> > ===================================================================
> > --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
> > +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
> > @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> > * We could run as a real-time thread. However, thus far
> > * this doesn't seem to be necessary.
> > */
> > -// tsk->policy = SCHED_FIFO;
> > -// tsk->rt_priority = 1;
> > +// struct sched_param param = { .sched_priority = 1 };
> > +//
> > +// sched_setscheduler(tsk, SCHED_FIFO, ¶m);
>
> Can we please remove the unused code completely instead of replacing it
> by more commented out code ?
It's OK to me, but I'm not the driver writer and doesn't know how important
are those comments. If removing them is better for driver writers too, here
is the patch.
Thanks,
Satoru
---
Remove unnecesary comments on driver for UCB1x00-based touchscreens.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
===================================================================
--- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
+++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-14 08:44:03.000000000 +0900
@@ -199,7 +199,7 @@ static inline int ucb1x00_ts_pen_down(st
}
/*
- * This is a RT kernel thread that handles the ADC accesses
+ * This is a kernel thread that handles the ADC accesses
* (mainly so we can use semaphores in the UCB1200 core code
* to serialise accesses to the ADC).
*/
@@ -210,13 +210,6 @@ static int ucb1x00_thread(void *_ts)
DECLARE_WAITQUEUE(wait, tsk);
int valid;
- /*
- * We could run as a real-time thread. However, thus far
- * this doesn't seem to be necessary.
- */
-// tsk->policy = SCHED_FIFO;
-// tsk->rt_priority = 1;
-
valid = 0;
add_wait_queue(&ts->irq_wait, &wait);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler
2007-05-13 23:56 ` Satoru Takeuchi
@ 2007-05-14 9:21 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2007-05-14 9:21 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: tglx, Linux Kernel, Russell King
Hi!
> > > Index: linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c
> > > ===================================================================
> > > --- linux-2.6.21-fix-ucb-drivers.orig/drivers/mfd/ucb1x00-ts.c 2007-05-11 18:53:36.000000000 +0900
> > > +++ linux-2.6.21-fix-ucb-drivers/drivers/mfd/ucb1x00-ts.c 2007-05-11 19:33:20.000000000 +0900
> > > @@ -214,8 +214,9 @@ static int ucb1x00_thread(void *_ts)
> > > * We could run as a real-time thread. However, thus far
> > > * this doesn't seem to be necessary.
> > > */
> > > -// tsk->policy = SCHED_FIFO;
> > > -// tsk->rt_priority = 1;
> > > +// struct sched_param param = { .sched_priority = 1 };
> > > +//
> > > +// sched_setscheduler(tsk, SCHED_FIFO, ¶m);
> >
> > Can we please remove the unused code completely instead of replacing it
> > by more commented out code ?
>
> It's OK to me, but I'm not the driver writer and doesn't know how important
> are those comments. If removing them is better for driver writers too, here
> is the patch.
I doubt anyone cares either way. Feel free to add my ACK to either
"remove" or "fix" version.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-05-14 9:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-11 10:39 [PATCH] Fix UCB1x00 driver to use sched_setscheduler Satoru Takeuchi
2007-05-11 11:32 ` Pavel Machek
2007-05-12 13:10 ` Thomas Gleixner
2007-05-13 23:56 ` Satoru Takeuchi
2007-05-14 9:21 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®