[PATCH] net: myri10ge: force select inet_lro

[PATCH] net: myri10ge: force select inet_lro

[Daniel Walker]

This driver uses the inet_lro facilities , but it doesn't force it
to be enabled .. Someone would have to know to enable inet_lro if
they select the driver .. 

Instead, just force INET_LRO if this driver is selected..

Signed-off-by: Daniel Walker <dwalker@mvista.com>

---
 drivers/net/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.22/drivers/net/Kconfig
===================================================================
--- linux-2.6.22.orig/drivers/net/Kconfig
+++ linux-2.6.22/drivers/net/Kconfig
@@ -2103,6 +2103,7 @@ source "drivers/net/ixp2000/Kconfig"
 config MYRI_SBUS
 	tristate "MyriCOM Gigabit Ethernet support"
 	depends on SBUS
+	select INET_LRO
 	help
 	  This driver supports MyriCOM Sbus gigabit Ethernet cards.
 
-- 

-- 

Re: [PATCH] net: myri10ge: force select inet_lro

[David Miller]

From: Daniel Walker <dwalker@mvista.com>
Date: Fri, 07 Sep 2007 13:26:25 -0700

> This driver uses the inet_lro facilities , but it doesn't force it
> to be enabled .. Someone would have to know to enable inet_lro if
> they select the driver .. 
> 
> Instead, just force INET_LRO if this driver is selected..
> 
> Signed-off-by: Daniel Walker <dwalker@mvista.com>

I put this exact fix into the net-2.6.24 tree several days ago
already, it's not nice that you didn't even bother checking.

When I saw the response to the help@ address, I could almost predict
that the myri10ge developers would not even check if net-2.6.24 had
the issue cured already.

Therefore, your patch doesn't even apply to the tree where it is
relevant.  That sucks.

Re: [PATCH] net: myri10ge: force select inet_lro

[Daniel Walker]

On Sat, 2007-09-08 at 01:22 -0700, David Miller wrote:
> From: Daniel Walker <dwalker@mvista.com>
> Date: Fri, 07 Sep 2007 13:26:25 -0700
> 
> > This driver uses the inet_lro facilities , but it doesn't force it
> > to be enabled .. Someone would have to know to enable inet_lro if
> > they select the driver .. 
> > 
> > Instead, just force INET_LRO if this driver is selected..
> > 
> > Signed-off-by: Daniel Walker <dwalker@mvista.com>
> 
> I put this exact fix into the net-2.6.24 tree several days ago
> already, it's not nice that you didn't even bother checking.

Sorry..

> When I saw the response to the help@ address, I could almost predict
> that the myri10ge developers would not even check if net-2.6.24 had
> the issue cured already.
> 
> Therefore, your patch doesn't even apply to the tree where it is
> relevant.  That sucks.

Not sure what the help@ address is ? I'm just trying to fix problems I
find .. This problem is in -mm which is what I was using. The driver is
pretty obscure, and I just assumed not many people would be building it.
So I didn't check for fixes in git ..

Did your fix go to LKML ?

Daniel

Re: [PATCH] net: myri10ge: force select inet_lro

[David Miller]

From: Daniel Walker <dwalker@mvista.com>
Date: Sat, 08 Sep 2007 09:03:06 -0700

> Did your fix go to LKML ?

I don't remember exactly.