* [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message
@ 2008-02-19 0:44 Jan Altenberg
2008-02-19 2:14 ` David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: Jan Altenberg @ 2008-02-19 0:44 UTC (permalink / raw)
To: David Brownell; +Cc: tglx, Greg KH, linux-kernel
Hi all,
commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which
prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This
breaks the RNDIS initialization (especially / only Windoze machines
dislike this behavior...).
Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
---
drivers/usb/gadget/ether.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6.24/drivers/usb/gadget/ether.c
===================================================================
--- linux-2.6.24.orig/drivers/usb/gadget/ether.c
+++ linux-2.6.24/drivers/usb/gadget/ether.c
@@ -1568,6 +1568,7 @@ done_set_intf:
memcpy(req->buf, buf, n);
req->complete = rndis_response_complete;
rndis_free_response(dev->rndis_config, buf);
+ value = n;
}
/* else stalls ... spec says to avoid that */
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message
2008-02-19 0:44 [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message Jan Altenberg
@ 2008-02-19 2:14 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2008-02-19 2:14 UTC (permalink / raw)
To: Jan Altenberg; +Cc: tglx, Greg KH, linux-kernel
On Monday 18 February 2008, Jan Altenberg wrote:
> Hi all,
>
> commit 0cf4f2de0a0f4100795f38ef894d4910678c74f8 introduced a bug, which
> prevents sending an USB_CDC_GET_ENCAPSULATED_RESPONSE message. This
> breaks the RNDIS initialization (especially / only Windoze machines
> dislike this behavior...).
>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> Signed-off-by: Jan Altenberg <jan.altenberg@linutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/usb/gadget/ether.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6.24/drivers/usb/gadget/ether.c
> ===================================================================
> --- linux-2.6.24.orig/drivers/usb/gadget/ether.c
> +++ linux-2.6.24/drivers/usb/gadget/ether.c
> @@ -1568,6 +1568,7 @@ done_set_intf:
> memcpy(req->buf, buf, n);
> req->complete = rndis_response_complete;
> rndis_free_response(dev->rndis_config, buf);
> + value = n;
> }
> /* else stalls ... spec says to avoid that */
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-19 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-19 0:44 [PATCH] queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message Jan Altenberg
2008-02-19 2:14 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®