From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: linux-kernel@vger.kernel.org
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Ivo van Doorn <IvDoorn@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Dmitry Torokhov <dtor@mail.ru>
Subject: [PATCH 1/8] rfkill: clarify meaning of rfkill states
Date: Fri, 11 Apr 2008 17:37:17 -0300 [thread overview]
Message-ID: <1207946244-14525-2-git-send-email-hmh@hmh.eng.br> (raw)
In-Reply-To: <1207946244-14525-1-git-send-email-hmh@hmh.eng.br>
rfkill really should have been named rfswitch. As it is, one can get
confused whether RFKILL_STATE_ON means the KILL switch is on (and
therefore, the radio is being *blocked* from operating), or whether it
means the RADIO rf output is on.
Clearly state that RFKILL_STATE_ON means the radio is *unblocked* from
operating (i.e. there is no rf killing going on).
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Ivo van Doorn <IvDoorn@gmail.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
---
include/linux/rfkill.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index e3ab21d..ca89ae1 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -44,8 +44,8 @@ enum rfkill_type {
};
enum rfkill_state {
- RFKILL_STATE_OFF = 0,
- RFKILL_STATE_ON = 1,
+ RFKILL_STATE_OFF = 0, /* Radio output blocked */
+ RFKILL_STATE_ON = 1, /* Radio output active */
};
/**
@@ -53,7 +53,7 @@ enum rfkill_state {
* @name: Name of the switch.
* @type: Radio type which the button controls, the value stored
* here should be a value from enum rfkill_type.
- * @state: State of the switch (on/off).
+ * @state: State of the switch, "ON" means radio can operate.
* @user_claim_unsupported: Whether the hardware supports exclusive
* RF-kill control by userspace. Set this before registering.
* @user_claim: Set when the switch is controlled exlusively by userspace.
--
1.5.4.4
next prev parent reply other threads:[~2008-04-11 20:37 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 20:37 [GIT PATCH] rfkill support for r/w and r/o rfkill switches Henrique de Moraes Holschuh
2008-04-11 20:37 ` Henrique de Moraes Holschuh [this message]
2008-04-14 4:22 ` [PATCH 1/8] rfkill: clarify meaning of rfkill states Dmitry Torokhov
2008-04-11 20:37 ` [PATCH 2/8] rfkill: fix minor typo in kernel doc Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:05 ` Henrique de Moraes Holschuh
2008-04-12 12:23 ` Ivo van Doorn
2008-04-12 13:08 ` Henrique de Moraes Holschuh
2008-04-12 13:17 ` Ivo van Doorn
2008-04-12 15:47 ` Dmitry Torokhov
2008-04-12 18:02 ` Henrique de Moraes Holschuh
2008-04-12 18:14 ` Ivo van Doorn
2008-04-12 19:09 ` Carlos Corbacho
2008-04-12 20:36 ` Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 4/8] rfkill: add read-write rfkill switch support Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-14 1:20 ` Henrique de Moraes Holschuh
2008-04-14 12:00 ` Ivo van Doorn
2008-04-14 14:16 ` Dmitry Torokhov
2008-04-14 14:36 ` Henrique de Moraes Holschuh
2008-04-14 15:19 ` Dmitry Torokhov
2008-04-14 16:33 ` Henrique de Moraes Holschuh
2008-04-14 18:05 ` Dmitry Torokhov
2008-04-14 21:41 ` Henrique de Moraes Holschuh
2008-04-14 19:06 ` Carlos Corbacho
2008-04-14 20:23 ` Dmitry Torokhov
2008-04-15 7:27 ` Carlos Corbacho
2008-04-15 12:58 ` Dmitry Torokhov
2008-04-14 21:04 ` Ivo van Doorn
2008-04-14 21:46 ` Henrique de Moraes Holschuh
2008-04-15 8:14 ` Ivo Van Doorn
2008-04-11 20:37 ` [PATCH 5/8] rfkill: add read-only " Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 6/8] rfkill: add the WWAN radio type Henrique de Moraes Holschuh
2008-04-11 20:44 ` Inaky Perez-Gonzalez
2008-04-11 20:53 ` Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:15 ` Henrique de Moraes Holschuh
2008-04-12 12:28 ` Ivo van Doorn
2008-04-12 23:23 ` Inaky Perez-Gonzalez
2008-04-13 17:25 ` Henrique de Moraes Holschuh
2008-04-13 17:37 ` Ivo van Doorn
2008-04-13 18:16 ` Henrique de Moraes Holschuh
2008-04-14 4:20 ` Dmitry Torokhov
2008-04-11 20:37 ` [PATCH 7/8] rfkill: add an "any radio" switch type and functionality Henrique de Moraes Holschuh
2008-04-12 19:57 ` Pavel Machek
2008-04-13 17:40 ` Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 8/8] rfkill: add parameter to disable radios by default Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:56 ` Henrique de Moraes Holschuh
2008-04-12 13:43 ` Ivo van Doorn
2008-04-12 14:43 ` Henrique de Moraes Holschuh
2008-04-12 16:24 ` Ivo van Doorn
2008-04-12 18:36 ` Henrique de Moraes Holschuh
2008-04-12 19:15 ` Ivo van Doorn
2008-04-12 10:36 ` [GIT PATCH] rfkill support for r/w and r/o rfkill switches Ivo van Doorn
2008-04-16 18:37 ` John W. Linville
2008-04-16 19:26 ` Ivo van Doorn
2008-04-16 19:58 ` John W. Linville
2008-04-16 20:40 ` Ivo van Doorn
2008-04-17 1:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207946244-14525-2-git-send-email-hmh@hmh.eng.br \
--to=hmh@hmh.eng.br \
--cc=IvDoorn@gmail.com \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®