From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-kernel@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
Date: Tue, 15 Apr 2008 08:27:49 +0100 [thread overview]
Message-ID: <200804150827.49936.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <20080414162209.ZZRA012@mailhub.coreip.homeip.net>
On Monday 14 April 2008 21:23:14 Dmitry Torokhov wrote:
> On Mon, Apr 14, 2008 at 08:06:50PM +0100, Carlos Corbacho wrote:
> > I agree wholeheartedly with Henrique here though - wireless drivers
> > should _not_ be using key press events as a reporting mechanism.
>
> Reporting mechanism for what exacly though? Depending on what you are
> talking about we either agree or disagree here ;)
Reporting state change in this case. For instance, KEY_WLAN means exactly
that - a user pressed a key that was mapped to KEY_WLAN. It's not a generic
notifier for any and all wireless events, state changes, etc.
If wireless drivers want to report a state change, then we need a proper
mechanism for that, as has already been discussed by Henrique.
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2008-04-15 7:28 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 20:37 [GIT PATCH] rfkill support for r/w and r/o rfkill switches Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 1/8] rfkill: clarify meaning of rfkill states Henrique de Moraes Holschuh
2008-04-14 4:22 ` Dmitry Torokhov
2008-04-11 20:37 ` [PATCH 2/8] rfkill: fix minor typo in kernel doc Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:05 ` Henrique de Moraes Holschuh
2008-04-12 12:23 ` Ivo van Doorn
2008-04-12 13:08 ` Henrique de Moraes Holschuh
2008-04-12 13:17 ` Ivo van Doorn
2008-04-12 15:47 ` Dmitry Torokhov
2008-04-12 18:02 ` Henrique de Moraes Holschuh
2008-04-12 18:14 ` Ivo van Doorn
2008-04-12 19:09 ` Carlos Corbacho
2008-04-12 20:36 ` Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 4/8] rfkill: add read-write rfkill switch support Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-14 1:20 ` Henrique de Moraes Holschuh
2008-04-14 12:00 ` Ivo van Doorn
2008-04-14 14:16 ` Dmitry Torokhov
2008-04-14 14:36 ` Henrique de Moraes Holschuh
2008-04-14 15:19 ` Dmitry Torokhov
2008-04-14 16:33 ` Henrique de Moraes Holschuh
2008-04-14 18:05 ` Dmitry Torokhov
2008-04-14 21:41 ` Henrique de Moraes Holschuh
2008-04-14 19:06 ` Carlos Corbacho
2008-04-14 20:23 ` Dmitry Torokhov
2008-04-15 7:27 ` Carlos Corbacho [this message]
2008-04-15 12:58 ` Dmitry Torokhov
2008-04-14 21:04 ` Ivo van Doorn
2008-04-14 21:46 ` Henrique de Moraes Holschuh
2008-04-15 8:14 ` Ivo Van Doorn
2008-04-11 20:37 ` [PATCH 5/8] rfkill: add read-only " Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 6/8] rfkill: add the WWAN radio type Henrique de Moraes Holschuh
2008-04-11 20:44 ` Inaky Perez-Gonzalez
2008-04-11 20:53 ` Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:15 ` Henrique de Moraes Holschuh
2008-04-12 12:28 ` Ivo van Doorn
2008-04-12 23:23 ` Inaky Perez-Gonzalez
2008-04-13 17:25 ` Henrique de Moraes Holschuh
2008-04-13 17:37 ` Ivo van Doorn
2008-04-13 18:16 ` Henrique de Moraes Holschuh
2008-04-14 4:20 ` Dmitry Torokhov
2008-04-11 20:37 ` [PATCH 7/8] rfkill: add an "any radio" switch type and functionality Henrique de Moraes Holschuh
2008-04-12 19:57 ` Pavel Machek
2008-04-13 17:40 ` Henrique de Moraes Holschuh
2008-04-11 20:37 ` [PATCH 8/8] rfkill: add parameter to disable radios by default Henrique de Moraes Holschuh
2008-04-12 10:36 ` Ivo van Doorn
2008-04-12 12:56 ` Henrique de Moraes Holschuh
2008-04-12 13:43 ` Ivo van Doorn
2008-04-12 14:43 ` Henrique de Moraes Holschuh
2008-04-12 16:24 ` Ivo van Doorn
2008-04-12 18:36 ` Henrique de Moraes Holschuh
2008-04-12 19:15 ` Ivo van Doorn
2008-04-12 10:36 ` [GIT PATCH] rfkill support for r/w and r/o rfkill switches Ivo van Doorn
2008-04-16 18:37 ` John W. Linville
2008-04-16 19:26 ` Ivo van Doorn
2008-04-16 19:58 ` John W. Linville
2008-04-16 20:40 ` Ivo van Doorn
2008-04-17 1:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804150827.49936.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®