mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, tglx@linutronix.de, mingo@elte.hu,
	Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH] Make x86 latest boot with non-discontig boxes
Date: Wed,  4 Jun 2008 01:08:27 -0300	[thread overview]
Message-ID: <1212552507-15134-1-git-send-email-gcosta@redhat.com> (raw)

Commit 0596152388e234efebce464355186ad9e16c8cb6
broke my box, since it removes completely the call to
memory_present() at e820 setup.

It seems to be really not needed with discontig memory,
but with flat and sparse, I get an early crash. The proposed patch
moves the call memory_present() to setup_memory, the one
present in setup_32.c.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
CC: Yinghai Lu <yhlu.kernel@gmail.com>
---
 arch/x86/kernel/setup_32.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
index 2901042..841eb2f 100644
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
@@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
 #ifdef CONFIG_FLATMEM
 	max_mapnr = num_physpages;
 #endif
+	memory_present(0, 0, max_pfn);
+
 	printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
 			pages_to_mb(max_low_pfn));
 
-- 
1.5.4.5


             reply	other threads:[~2008-06-04  4:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  4:08 Glauber Costa [this message]
2008-06-04  4:51 ` Yinghai Lu
2008-06-04  5:20   ` Glauber Costa
2008-06-04  6:26     ` Yinghai Lu
2008-06-04 10:36 ` Ingo Molnar
2008-06-04 13:21   ` Glauber Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212552507-15134-1-git-send-email-gcosta@redhat.com \
    --to=gcosta@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®