Re: [PATCH] Make x86 latest boot with non-discontig boxes

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On Tue, Jun 3, 2008 at 10:20 PM, Glauber Costa <glommer@gmail.com> wrote:
> On Wed, Jun 4, 2008 at 1:51 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>> On Tue, Jun 3, 2008 at 9:08 PM, Glauber Costa <gcosta@redhat.com> wrote:
>>> Commit 0596152388e234efebce464355186ad9e16c8cb6
>>> broke my box, since it removes completely the call to
>>> memory_present() at e820 setup.
>>>
>>> It seems to be really not needed with discontig memory,
>>> but with flat and sparse, I get an early crash. The proposed patch
>>> moves the call memory_present() to setup_memory, the one
>>> present in setup_32.c.
>>>
>>> Signed-off-by: Glauber Costa <gcosta@redhat.com>
>>> CC: Yinghai Lu <yhlu.kernel@gmail.com>
>>> ---
>>>  arch/x86/kernel/setup_32.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
>>> index 2901042..841eb2f 100644
>>> --- a/arch/x86/kernel/setup_32.c
>>> +++ b/arch/x86/kernel/setup_32.c
>>> @@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
>>>  #ifdef CONFIG_FLATMEM
>>>        max_mapnr = num_physpages;
>>>  #endif
>>> +       memory_present(0, 0, max_pfn);
>>> +
>>>        printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
>>>                        pages_to_mb(max_low_pfn));
>>>
>>> --
>> thanks
>>
>> http://lkml.org/lkml/2008/6/3/229
>> [PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix
>>
>> already address that.
>>
>> YH
>
> Great.
>
> I guess it was not on the tree yet, then.
>
yes

today sent out several

[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix
[PATCH] x86: early check if one system is numaq v2
[PATCH] x86: remove all active before register them again after trimming - 64bit
[PATCH] x86: numa32 make sure get kva space
[PATCH] x86: move e820_register_active to e820.c
[PATCH] x86: 32 bit use e820_register_active_regions

YH