From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Glauber Costa" <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
tglx@linutronix.de, mingo@elte.hu
Subject: Re: [PATCH] Make x86 latest boot with non-discontig boxes
Date: Tue, 3 Jun 2008 21:51:55 -0700 [thread overview]
Message-ID: <86802c440806032151l5faedf22xe0107d4c99c55c21@mail.gmail.com> (raw)
In-Reply-To: <1212552507-15134-1-git-send-email-gcosta@redhat.com>
On Tue, Jun 3, 2008 at 9:08 PM, Glauber Costa <gcosta@redhat.com> wrote:
> Commit 0596152388e234efebce464355186ad9e16c8cb6
> broke my box, since it removes completely the call to
> memory_present() at e820 setup.
>
> It seems to be really not needed with discontig memory,
> but with flat and sparse, I get an early crash. The proposed patch
> moves the call memory_present() to setup_memory, the one
> present in setup_32.c.
>
> Signed-off-by: Glauber Costa <gcosta@redhat.com>
> CC: Yinghai Lu <yhlu.kernel@gmail.com>
> ---
> arch/x86/kernel/setup_32.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
> index 2901042..841eb2f 100644
> --- a/arch/x86/kernel/setup_32.c
> +++ b/arch/x86/kernel/setup_32.c
> @@ -388,6 +388,8 @@ static unsigned long __init setup_memory(void)
> #ifdef CONFIG_FLATMEM
> max_mapnr = num_physpages;
> #endif
> + memory_present(0, 0, max_pfn);
> +
> printk(KERN_NOTICE "%ldMB LOWMEM available.\n",
> pages_to_mb(max_low_pfn));
>
> --
thanks
http://lkml.org/lkml/2008/6/3/229
[PATCH] x86: change propagate_e820_map back to find_max_pfn -32bit - fix
already address that.
YH
next prev parent reply other threads:[~2008-06-04 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 4:08 Glauber Costa
2008-06-04 4:51 ` Yinghai Lu [this message]
2008-06-04 5:20 ` Glauber Costa
2008-06-04 6:26 ` Yinghai Lu
2008-06-04 10:36 ` Ingo Molnar
2008-06-04 13:21 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440806032151l5faedf22xe0107d4c99c55c21@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®