[PATCH] ATM: horizon, fix hrz_probe fail path

[PATCH] ATM: horizon, fix hrz_probe fail path

[Jiri Slaby]

One fail path in hrz_probe omitted device disable. Fix it.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 drivers/atm/horizon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 6154123..6b969f8 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -2705,7 +2705,7 @@ static int __devinit hrz_probe(struct pci_dev *pci_dev, const struct pci_device_
 
 	/* XXX DEV_LABEL is a guess */
 	if (!request_region(iobase, HRZ_IO_EXTENT, DEV_LABEL)) {
-		return -EINVAL;
+		err = -EINVAL;
 		goto out_disable;
 	}
 
-- 
1.6.0.4

Re: [PATCH] ATM: horizon, fix hrz_probe fail path

[David Miller]

From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 29 Nov 2008 22:34:25 +0100

> One fail path in hrz_probe omitted device disable. Fix it.
> 
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

Applied, but please post all networking patches to
netdev@vger.kernel.org, in particular so that they
get properly tracked at:

	http://patchwork.ozlabs.org/project/netdev/list/

I feel like I type this in at least 10 times a day, so
people please start making sure netdev is on the CC: for
all networking patches.

Thanks!

> ---
>  drivers/atm/horizon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 6154123..6b969f8 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2705,7 +2705,7 @@ static int __devinit hrz_probe(struct pci_dev *pci_dev, const struct pci_device_
>  
>  	/* XXX DEV_LABEL is a guess */
>  	if (!request_region(iobase, HRZ_IO_EXTENT, DEV_LABEL)) {
> -		return -EINVAL;
> +		err = -EINVAL;
>  		goto out_disable;
>  	}
>  
> -- 
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] MAINTAINERS: add netdev to ATM

[Jiri Slaby]

David Miller wrote:
> > One fail path in hrz_probe omitted device disable. Fix it.
> > 
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> 
> Applied, but please post all networking patches to
> netdev@vger.kernel.org, in particular so that they
> get properly tracked at:
> 
> 	http://patchwork.ozlabs.org/project/netdev/list/
> 
> I feel like I type this in at least 10 times a day, so
> people please start making sure netdev is on the CC: for
> all networking patches.

Hmm, I didn't even think this is net related. I would expect such things to
be in drivers/net/ then. Consider the patch below for applying.

--

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 MAINTAINERS |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e17fa7d..6035710 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -779,6 +779,7 @@ ATM
 P:	Chas Williams
 M:	chas@cmf.nrl.navy.mil
 L:	linux-atm-general@lists.sourceforge.net (subscribers-only)
+L:	netdev@vger.kernel.org
 W:	http://linux-atm.sourceforge.net
 S:	Maintained
 
-- 
1.6.0.4

Re: [PATCH] MAINTAINERS: add netdev to ATM

[David Miller]

From: Jiri Slaby <jirislaby@gmail.com>
Date: Sun, 30 Nov 2008 09:23:09 +0100

> David Miller wrote:
> > > One fail path in hrz_probe omitted device disable. Fix it.
> > > 
> > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> > 
> > Applied, but please post all networking patches to
> > netdev@vger.kernel.org, in particular so that they
> > get properly tracked at:
> > 
> > 	http://patchwork.ozlabs.org/project/netdev/list/
> > 
> > I feel like I type this in at least 10 times a day, so
> > people please start making sure netdev is on the CC: for
> > all networking patches.
> 
> Hmm, I didn't even think this is net related. I would expect such things to
> be in drivers/net/ then. Consider the patch below for applying.
> 
> --
> 
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

Applied, thanks Jiri!