From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 13/14] [VOYAGER] x86/voyager: remove direct use of pg0 in favour of early_ioremap()
Date: Tue, 14 Apr 2009 10:51:39 -0500 [thread overview]
Message-ID: <1239724300-16371-14-git-send-email-James.Bottomley@HansenPartnership.com> (raw)
In-Reply-To: <1239724300-16371-13-git-send-email-James.Bottomley@HansenPartnership.com>
This was a hold over from the days when we didn't actually have an
early_ioremap() and we had to fiddle with the kernel page table
directly to read voyager cmos clickmap entries.
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
arch/x86/mach-voyager/voyager_basic.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/x86/mach-voyager/voyager_basic.c b/arch/x86/mach-voyager/voyager_basic.c
index 7c97c9a..5d37967 100644
--- a/arch/x86/mach-voyager/voyager_basic.c
+++ b/arch/x86/mach-voyager/voyager_basic.c
@@ -123,7 +123,6 @@ int __init voyager_memory_detect(int region, __u32 * start, __u32 * length)
__u8 cmos[4];
ClickMap_t *map;
unsigned long map_addr;
- unsigned long old;
if (region >= CLICK_ENTRIES) {
printk("Voyager: Illegal ClickMap region %d\n", region);
@@ -135,13 +134,7 @@ int __init voyager_memory_detect(int region, __u32 * start, __u32 * length)
voyager_extended_cmos_read(VOYAGER_MEMORY_CLICKMAP + i);
map_addr = *(unsigned long *)cmos;
-
- /* steal page 0 for this */
- old = pg0[0];
- pg0[0] = ((map_addr & PAGE_MASK) | _PAGE_RW | _PAGE_PRESENT);
- local_flush_tlb();
- /* now clear everything out but page 0 */
- map = (ClickMap_t *) (map_addr & (~PAGE_MASK));
+ map = (ClickMap_t *)early_ioremap(map_addr, sizeof(*map));
/* zero length is the end of the clickmap */
if (map->Entry[region].Length != 0) {
@@ -149,10 +142,8 @@ int __init voyager_memory_detect(int region, __u32 * start, __u32 * length)
*start = map->Entry[region].Address;
retval = 1;
}
+ early_iounmap(map, sizeof(*map));
- /* replace the mapping */
- pg0[0] = old;
- local_flush_tlb();
return retval;
}
--
1.6.2.1
next prev parent reply other threads:[~2009-04-14 15:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 15:51 [PATCH 00/14] convert voyager over to the x86 quirks model James Bottomley
2009-04-14 15:51 ` [PATCH 01/14] [VOYAGER] x86: add {safe,hard}_smp_processor_id to smp_ops James Bottomley
2009-04-14 15:51 ` [PATCH 02/14] [VOYAGER] x86/mca: make mca_nmi_hook external James Bottomley
2009-04-14 15:51 ` [PATCH 03/14] [VOYAGER] x86: add prefill_possible_map to x86_quirks James Bottomley
2009-04-14 15:51 ` [PATCH 04/14] [VOYAGER] x86: use boot_cpu_id instead of zero for checking boot processor James Bottomley
2009-04-14 15:51 ` [PATCH 05/14] [VOYAGER] x86/voyager: Move voyager detection to a new bootparam area James Bottomley
2009-04-14 15:51 ` [PATCH 06/14] [VOYAGER] x86: eliminate subarchitecture file setup_arch.h James Bottomley
2009-04-14 15:51 ` [PATCH 07/14] [VOYAGER] x86: eliminate subarchitecture file entry_arch.h James Bottomley
2009-04-14 15:51 ` [PATCH 08/14] [VOYAGER] x86: eliminate subarchitecture file do_timer.h James Bottomley
2009-04-14 15:51 ` [PATCH 09/14] [VOYAGER] x86: redo irq2 cascade setup James Bottomley
2009-04-14 15:51 ` [PATCH 10/14] [VOYAGER] x86: make disabling the apics functional instead of a flag James Bottomley
2009-04-14 15:51 ` [PATCH 11/14] [VOYAGER] x86/Voyager: add missing QIC call function single gate James Bottomley
2009-04-14 15:51 ` [PATCH 12/14] [VOYAGER] x86/Voyager: replace inline io area reads with readX accessors James Bottomley
2009-04-14 15:51 ` James Bottomley [this message]
2009-04-14 15:51 ` [PATCH 14/14] [VOYAGER] x86/Voyager: Plumb voyager back into the build James Bottomley
2009-04-14 17:09 ` [PATCH 10/14] [VOYAGER] x86: make disabling the apics functional instead of a flag Cyrill Gorcunov
2009-04-14 17:44 ` Cyrill Gorcunov
2009-04-15 12:51 ` James Bottomley
2009-04-15 14:12 ` Cyrill Gorcunov
2009-04-14 16:31 ` [PATCH 01/14] [VOYAGER] x86: add {safe,hard}_smp_processor_id to smp_ops Cyrill Gorcunov
2009-04-14 16:54 ` James Bottomley
2009-04-14 16:35 ` Jeremy Fitzhardinge
2009-04-14 16:57 ` James Bottomley
2009-04-14 16:27 ` [PATCH 00/14] convert voyager over to the x86 quirks model Joe Perches
2009-04-14 16:57 ` Ingo Molnar
2009-04-14 18:08 ` Ingo Molnar
2009-04-14 23:12 ` James Bottomley
2009-04-15 15:35 ` Ingo Molnar
2009-04-16 21:06 ` James Bottomley
2009-04-16 20:54 ` Jeff Garzik
2009-04-19 23:35 ` Ingo Molnar
2009-04-19 23:54 ` Jeff Garzik
2009-04-20 0:38 ` Ingo Molnar
2009-04-20 16:59 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239724300-16371-14-git-send-email-James.Bottomley@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®