From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH 01/14] [VOYAGER] x86: add {safe,hard}_smp_processor_id to smp_ops
Date: Tue, 14 Apr 2009 10:51:27 -0500 [thread overview]
Message-ID: <1239724300-16371-2-git-send-email-James.Bottomley@HansenPartnership.com> (raw)
In-Reply-To: <1239724300-16371-1-git-send-email-James.Bottomley@HansenPartnership.com>
Not having apics, Voyager can't use the default apic implementation of
these, it has to read from a special port in the VIC to get the
processor ID, so abstract these functions in smp_ops to allow voyager
to live simultaneously with the apic code.
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
arch/x86/include/asm/smp.h | 13 +++++++++++--
arch/x86/kernel/apic/apic.c | 5 -----
arch/x86/kernel/apic/ipi.c | 2 +-
arch/x86/kernel/smp.c | 7 +++++++
arch/x86/xen/smp.c | 7 +++++++
5 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
index 19e0d88..aac866f 100644
--- a/arch/x86/include/asm/smp.h
+++ b/arch/x86/include/asm/smp.h
@@ -60,6 +60,8 @@ struct smp_ops {
void (*send_call_func_ipi)(const struct cpumask *mask);
void (*send_call_func_single_ipi)(int cpu);
+ int (*hard_smp_processor_id)(void);
+ int (*safe_smp_processor_id)(void);
};
/* Globals due to paravirt */
@@ -159,7 +161,11 @@ extern unsigned disabled_cpus __cpuinitdata;
* so this is correct in the x86 case.
*/
#define raw_smp_processor_id() (percpu_read(cpu_number))
-extern int safe_smp_processor_id(void);
+int apic_safe_smp_processor_id(void);
+static inline int safe_smp_processor_id(void)
+{
+ return smp_ops.safe_smp_processor_id();
+}
#elif defined(CONFIG_X86_64_SMP)
#define raw_smp_processor_id() (percpu_read(cpu_number))
@@ -185,7 +191,10 @@ static inline int logical_smp_processor_id(void)
#endif
-extern int hard_smp_processor_id(void);
+static inline int hard_smp_processor_id(void)
+{
+ return smp_ops.hard_smp_processor_id();
+}
#else /* CONFIG_X86_LOCAL_APIC */
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index f287092..f9e830e 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1885,11 +1885,6 @@ void __cpuinit generic_processor_info(int apicid, int version)
set_cpu_present(cpu, true);
}
-int hard_smp_processor_id(void)
-{
- return read_apic_id();
-}
-
void default_init_apic_ldr(void)
{
unsigned long val;
diff --git a/arch/x86/kernel/apic/ipi.c b/arch/x86/kernel/apic/ipi.c
index dbf5445..90bb775 100644
--- a/arch/x86/kernel/apic/ipi.c
+++ b/arch/x86/kernel/apic/ipi.c
@@ -146,7 +146,7 @@ static int convert_apicid_to_cpu(int apic_id)
return -1;
}
-int safe_smp_processor_id(void)
+int apic_safe_smp_processor_id(void)
{
int apicid, cpuid;
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 13f33ea..29d0af7 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -192,6 +192,11 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
irq_exit();
}
+static int native_hard_smp_processor_id(void)
+{
+ return read_apic_id();
+}
+
struct smp_ops smp_ops = {
.smp_prepare_boot_cpu = native_smp_prepare_boot_cpu,
.smp_prepare_cpus = native_smp_prepare_cpus,
@@ -207,5 +212,7 @@ struct smp_ops smp_ops = {
.send_call_func_ipi = native_send_call_func_ipi,
.send_call_func_single_ipi = native_send_call_func_single_ipi,
+ .hard_smp_processor_id = native_hard_smp_processor_id,
+ .safe_smp_processor_id = apic_safe_smp_processor_id,
};
EXPORT_SYMBOL_GPL(smp_ops);
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 429834e..eb795bf 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -454,6 +454,11 @@ static irqreturn_t xen_call_function_single_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
+static int xen_hard_smp_processor_id(void)
+{
+ return read_apic_id();
+}
+
static const struct smp_ops xen_smp_ops __initdata = {
.smp_prepare_boot_cpu = xen_smp_prepare_boot_cpu,
.smp_prepare_cpus = xen_smp_prepare_cpus,
@@ -469,6 +474,8 @@ static const struct smp_ops xen_smp_ops __initdata = {
.send_call_func_ipi = xen_smp_send_call_function_ipi,
.send_call_func_single_ipi = xen_smp_send_call_function_single_ipi,
+ .hard_smp_processor_id = xen_hard_smp_processor_id,
+ .safe_smp_processor_id = apic_safe_smp_processor_id,
};
void __init xen_smp_init(void)
--
1.6.2.1
next prev parent reply other threads:[~2009-04-14 15:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-14 15:51 [PATCH 00/14] convert voyager over to the x86 quirks model James Bottomley
2009-04-14 15:51 ` James Bottomley [this message]
2009-04-14 15:51 ` [PATCH 02/14] [VOYAGER] x86/mca: make mca_nmi_hook external James Bottomley
2009-04-14 15:51 ` [PATCH 03/14] [VOYAGER] x86: add prefill_possible_map to x86_quirks James Bottomley
2009-04-14 15:51 ` [PATCH 04/14] [VOYAGER] x86: use boot_cpu_id instead of zero for checking boot processor James Bottomley
2009-04-14 15:51 ` [PATCH 05/14] [VOYAGER] x86/voyager: Move voyager detection to a new bootparam area James Bottomley
2009-04-14 15:51 ` [PATCH 06/14] [VOYAGER] x86: eliminate subarchitecture file setup_arch.h James Bottomley
2009-04-14 15:51 ` [PATCH 07/14] [VOYAGER] x86: eliminate subarchitecture file entry_arch.h James Bottomley
2009-04-14 15:51 ` [PATCH 08/14] [VOYAGER] x86: eliminate subarchitecture file do_timer.h James Bottomley
2009-04-14 15:51 ` [PATCH 09/14] [VOYAGER] x86: redo irq2 cascade setup James Bottomley
2009-04-14 15:51 ` [PATCH 10/14] [VOYAGER] x86: make disabling the apics functional instead of a flag James Bottomley
2009-04-14 15:51 ` [PATCH 11/14] [VOYAGER] x86/Voyager: add missing QIC call function single gate James Bottomley
2009-04-14 15:51 ` [PATCH 12/14] [VOYAGER] x86/Voyager: replace inline io area reads with readX accessors James Bottomley
2009-04-14 15:51 ` [PATCH 13/14] [VOYAGER] x86/voyager: remove direct use of pg0 in favour of early_ioremap() James Bottomley
2009-04-14 15:51 ` [PATCH 14/14] [VOYAGER] x86/Voyager: Plumb voyager back into the build James Bottomley
2009-04-14 17:09 ` [PATCH 10/14] [VOYAGER] x86: make disabling the apics functional instead of a flag Cyrill Gorcunov
2009-04-14 17:44 ` Cyrill Gorcunov
2009-04-15 12:51 ` James Bottomley
2009-04-15 14:12 ` Cyrill Gorcunov
2009-04-14 16:31 ` [PATCH 01/14] [VOYAGER] x86: add {safe,hard}_smp_processor_id to smp_ops Cyrill Gorcunov
2009-04-14 16:54 ` James Bottomley
2009-04-14 16:35 ` Jeremy Fitzhardinge
2009-04-14 16:57 ` James Bottomley
2009-04-14 16:27 ` [PATCH 00/14] convert voyager over to the x86 quirks model Joe Perches
2009-04-14 16:57 ` Ingo Molnar
2009-04-14 18:08 ` Ingo Molnar
2009-04-14 23:12 ` James Bottomley
2009-04-15 15:35 ` Ingo Molnar
2009-04-16 21:06 ` James Bottomley
2009-04-16 20:54 ` Jeff Garzik
2009-04-19 23:35 ` Ingo Molnar
2009-04-19 23:54 ` Jeff Garzik
2009-04-20 0:38 ` Ingo Molnar
2009-04-20 16:59 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239724300-16371-2-git-send-email-James.Bottomley@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome