mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	niel.lambrechts@gmail.com
Subject: Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8
Date: Fri, 01 May 2009 10:16:45 +0200	[thread overview]
Message-ID: <1241165805.13562.2.camel@johannes.local> (raw)
In-Reply-To: <f7848160904301838q4883106fq8d31e2e7c0b10a14@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Parag,

> Niel bisected the probe timeouts with iwlagn to your commit
> 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8 .  I too was getting probe
> timeouts but with ath9k and tried reverting the above commit which
> made the problem disappear.

I know. There's a bug in that commit.

> It is not yet reverted from mainline and compat-wireless - just wanted
> to bring it to your notice that it impacts both iwlagn and ath9k.

I'm not sure what makes you think that it even _should_ be reverted.
Just to make that clear: it should _not_ be reverted. How did you check
that it isn't reverted in compat-wireless anyway? Must have been by code
inspection since if you had made an attempt to verify that the code in
there works, you would have found that indeed there's no reason to
revert this commit since the fix for it went in, and is literally a
single line.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-05-01  8:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  1:38 Parag Warudkar
2009-05-01  8:16 ` Johannes Berg [this message]
2009-05-01 13:19   ` Parag Warudkar
2009-05-11 17:57     ` Linus Torvalds
2009-05-11 18:10       ` Linus Torvalds
2009-05-11 18:22       ` Johannes Berg
2009-05-11 18:33         ` Linus Torvalds
2009-05-11 18:52           ` Johannes Berg
2009-05-11 19:14             ` Linus Torvalds
2009-05-11 20:21               ` Frans Pop
2009-05-01 20:28   ` Parag Warudkar
2009-05-02  8:27     ` Johannes Berg
2009-05-02 11:20       ` Parag Warudkar
2009-05-02 16:44         ` Johannes Berg
2009-05-02 18:13           ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241165805.13562.2.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niel.lambrechts@gmail.com \
    --cc=parag.lkml@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®