From: Parag Warudkar <parag.lkml@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
niel.lambrechts@gmail.com
Subject: Re: Probe Timeouts with 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8
Date: Fri, 1 May 2009 09:19:08 -0400 [thread overview]
Message-ID: <f7848160905010619n74372488n45a7b7abccfe5ea7@mail.gmail.com> (raw)
In-Reply-To: <1241165805.13562.2.camel@johannes.local>
On 5/1/09, Johannes Berg <johannes@sipsolutions.net> wrote:
> I'm not sure what makes you think that it even _should_ be reverted.
> Just to make that clear: it should _not_ be reverted. How did you check
> that it isn't reverted in compat-wireless anyway? Must have been by code
> inspection since if you had made an attempt to verify that the code in
> there works, you would have found that indeed there's no reason to
> revert this commit since the fix for it went in, and is literally a
> single line.
Well I have the 04-29 compat-wireless tree and it does not work - just
like mainline I get timeouts. I have not been able to download later
versions - clicking on the URL does nothing for some reason. (Besides
I do not normally track compat-wireless.)
So since I wasn't able to use the mainline for 2-3 days and I could
not find any regression/bug where it was mentioned the bug was fixed
in compat-wireless I thought it might be better to revert it until a
fix appears. (BTW, I just did a pull on Linus tree and the fix hasn't
made it there).
So unless I am being too unreasonable here I think reverting *was*
(not *is* of course now) the right thing to do based if nothing else,
on the fact that ath9k and iwlagn were unusable for 2+ days and not
everyone can be expected to run compat-wireless daily builds.
Any way now that we know there is a fix - I will wait for it to appear
in mainline.
Parag
next prev parent reply other threads:[~2009-05-01 13:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 1:38 Parag Warudkar
2009-05-01 8:16 ` Johannes Berg
2009-05-01 13:19 ` Parag Warudkar [this message]
2009-05-11 17:57 ` Linus Torvalds
2009-05-11 18:10 ` Linus Torvalds
2009-05-11 18:22 ` Johannes Berg
2009-05-11 18:33 ` Linus Torvalds
2009-05-11 18:52 ` Johannes Berg
2009-05-11 19:14 ` Linus Torvalds
2009-05-11 20:21 ` Frans Pop
2009-05-01 20:28 ` Parag Warudkar
2009-05-02 8:27 ` Johannes Berg
2009-05-02 11:20 ` Parag Warudkar
2009-05-02 16:44 ` Johannes Berg
2009-05-02 18:13 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7848160905010619n74372488n45a7b7abccfe5ea7@mail.gmail.com \
--to=parag.lkml@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=niel.lambrechts@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®