[PATCH] iwl3945: fix ia64/ppc build

[PATCH] iwl3945: fix ia64/ppc build

[Jan Beulich]

Exporting static and non-static symbols in the same compilation unit
results, on some architectures, in section mismatch errors from the
compiler. Since exporting static symbols is bogus altogether, simply
remove the offending export. Once at it, also remove the other export
commit df833b1d73680f9f9dc72cbc3215edbbc6ab740d pointlessly added.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: John W. Linville <linville@tuxdriver.com>

---
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 09:42:55.000000000 +0200
+++ 2.6.30-rc4-iwl3945-build/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-05-05 14:25:43.000000000 +0200
@@ -1694,7 +1694,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
 	rxq->free_count = 0;
 	spin_unlock_irqrestore(&rxq->lock, flags);
 }
-EXPORT_SYMBOL(iwl3945_rx_queue_reset);
 
 /*
  * this should be called while priv->lock is locked
@@ -1745,7 +1744,6 @@ static void iwl3945_rx_queue_free(struct
 	rxq->bd = NULL;
 	rxq->rb_stts  = NULL;
 }
-EXPORT_SYMBOL(iwl3945_rx_queue_free);
 
 
 /* Convert linear signal-to-noise ratio into dB */

Re: [PATCH] iwl3945: fix ia64/ppc build

[reinette chatre]

Jan,

On Tue, 2009-05-05 at 05:51 -0700, Jan Beulich wrote:
> Exporting static and non-static symbols in the same compilation unit
> results, on some architectures, in section mismatch errors from the
> compiler. Since exporting static symbols is bogus altogether, simply
> remove the offending export. Once at it, also remove the other export
> commit df833b1d73680f9f9dc72cbc3215edbbc6ab740d pointlessly added.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> 
> ---
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> --- linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-04-30 09:42:55.000000000 +0200
> +++ 2.6.30-rc4-iwl3945-build/drivers/net/wireless/iwlwifi/iwl3945-base.c	2009-05-05 14:25:43.000000000 +0200
> @@ -1694,7 +1694,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
>  	rxq->free_count = 0;
>  	spin_unlock_irqrestore(&rxq->lock, flags);
>  }
> -EXPORT_SYMBOL(iwl3945_rx_queue_reset);
>  
>  /*
>   * this should be called while priv->lock is locked
> @@ -1745,7 +1744,6 @@ static void iwl3945_rx_queue_free(struct
>  	rxq->bd = NULL;
>  	rxq->rb_stts  = NULL;
>  }
> -EXPORT_SYMBOL(iwl3945_rx_queue_free);
>  
> 
>  /* Convert linear signal-to-noise ratio into dB */
> 
> 
> 

These changes are already queued for 2.6.30 in wireless-2.6 as commit
6269b731560d69c5eaa929909891edec39496d71 and
3ee59f8d0dcab2e114546038b2b224776c82b7f7

Reinette