mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] IMA: remove read permissions on the ima policy file
@ 2009-05-12 19:13 Eric Paris
  2009-05-14 13:11 ` Mimi Zohar
  2009-05-15  0:40 ` James Morris
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Paris @ 2009-05-12 19:13 UTC (permalink / raw)
  To: zohar; +Cc: jmorris, linux-kernel

The IMA policy file does not implement read.  Trying to just open/read/close
the file will load a blank policy and you cannot then change the policy
without a reboot.  This removes the read permission from the file so one must
at least be attempting to write...

Signed-off-by: Eric Paris <eparis@redhat.com>
---

 security/integrity/ima/ima_fs.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
index 510186f..2a829da 100644
--- a/security/integrity/ima/ima_fs.c
+++ b/security/integrity/ima/ima_fs.c
@@ -15,6 +15,7 @@
  *	implemenents security file system for reporting
  *	current measurement list and IMA statistics
  */
+#include <linux/fcntl.h>
 #include <linux/module.h>
 #include <linux/seq_file.h>
 #include <linux/rculist.h>
@@ -283,6 +284,9 @@ static atomic_t policy_opencount = ATOMIC_INIT(1);
  */
 int ima_open_policy(struct inode * inode, struct file * filp)
 {
+	/* No point in being allowed to open it if you aren't going to write */
+	if (!(filp->f_flags & O_WRONLY))
+		return -EACCES;
 	if (atomic_dec_and_test(&policy_opencount))
 		return 0;
 	return -EBUSY;
@@ -349,7 +353,7 @@ int ima_fs_init(void)
 		goto out;
 
 	ima_policy = securityfs_create_file("policy",
-					    S_IRUSR | S_IRGRP | S_IWUSR,
+					    S_IWUSR,
 					    ima_dir, NULL,
 					    &ima_measure_policy_ops);
 	if (IS_ERR(ima_policy))


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] IMA: remove read permissions on the ima policy file
  2009-05-12 19:13 [PATCH] IMA: remove read permissions on the ima policy file Eric Paris
@ 2009-05-14 13:11 ` Mimi Zohar
  2009-05-15  0:40 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: Mimi Zohar @ 2009-05-14 13:11 UTC (permalink / raw)
  To: Eric Paris; +Cc: jmorris, linux-kernel, David Safford

On Tue, 2009-05-12 at 15:13 -0400, Eric Paris wrote:
> The IMA policy file does not implement read.  Trying to just open/read/close
> the file will load a blank policy and you cannot then change the policy
> without a reboot.  This removes the read permission from the file so one must
> at least be attempting to write...
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>

Acked-by: Mimi Zohar <zohar@us.ibm.com>

> ---
> 
>  security/integrity/ima/ima_fs.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
> index 510186f..2a829da 100644
> --- a/security/integrity/ima/ima_fs.c
> +++ b/security/integrity/ima/ima_fs.c
> @@ -15,6 +15,7 @@
>   *	implemenents security file system for reporting
>   *	current measurement list and IMA statistics
>   */
> +#include <linux/fcntl.h>
>  #include <linux/module.h>
>  #include <linux/seq_file.h>
>  #include <linux/rculist.h>
> @@ -283,6 +284,9 @@ static atomic_t policy_opencount = ATOMIC_INIT(1);
>   */
>  int ima_open_policy(struct inode * inode, struct file * filp)
>  {
> +	/* No point in being allowed to open it if you aren't going to write */
> +	if (!(filp->f_flags & O_WRONLY))
> +		return -EACCES;
>  	if (atomic_dec_and_test(&policy_opencount))
>  		return 0;
>  	return -EBUSY;
> @@ -349,7 +353,7 @@ int ima_fs_init(void)
>  		goto out;
> 
>  	ima_policy = securityfs_create_file("policy",
> -					    S_IRUSR | S_IRGRP | S_IWUSR,
> +					    S_IWUSR,
>  					    ima_dir, NULL,
>  					    &ima_measure_policy_ops);
>  	if (IS_ERR(ima_policy))
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] IMA: remove read permissions on the ima policy file
  2009-05-12 19:13 [PATCH] IMA: remove read permissions on the ima policy file Eric Paris
  2009-05-14 13:11 ` Mimi Zohar
@ 2009-05-15  0:40 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2009-05-15  0:40 UTC (permalink / raw)
  To: Eric Paris; +Cc: zohar, linux-kernel

On Tue, 12 May 2009, Eric Paris wrote:

> The IMA policy file does not implement read.  Trying to just open/read/close
> the file will load a blank policy and you cannot then change the policy
> without a reboot.  This removes the read permission from the file so one must
> at least be attempting to write...
> 
> Signed-off-by: Eric Paris <eparis@redhat.com>

Applied to 
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

> ---
> 
>  security/integrity/ima/ima_fs.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
> index 510186f..2a829da 100644
> --- a/security/integrity/ima/ima_fs.c
> +++ b/security/integrity/ima/ima_fs.c
> @@ -15,6 +15,7 @@
>   *	implemenents security file system for reporting
>   *	current measurement list and IMA statistics
>   */
> +#include <linux/fcntl.h>
>  #include <linux/module.h>
>  #include <linux/seq_file.h>
>  #include <linux/rculist.h>
> @@ -283,6 +284,9 @@ static atomic_t policy_opencount = ATOMIC_INIT(1);
>   */
>  int ima_open_policy(struct inode * inode, struct file * filp)
>  {
> +	/* No point in being allowed to open it if you aren't going to write */
> +	if (!(filp->f_flags & O_WRONLY))
> +		return -EACCES;
>  	if (atomic_dec_and_test(&policy_opencount))
>  		return 0;
>  	return -EBUSY;
> @@ -349,7 +353,7 @@ int ima_fs_init(void)
>  		goto out;
>  
>  	ima_policy = securityfs_create_file("policy",
> -					    S_IRUSR | S_IRGRP | S_IWUSR,
> +					    S_IWUSR,
>  					    ima_dir, NULL,
>  					    &ima_measure_policy_ops);
>  	if (IS_ERR(ima_policy))
> 

-- 
James Morris
<jmorris@namei.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-05-15  0:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-12 19:13 [PATCH] IMA: remove read permissions on the ima policy file Eric Paris
2009-05-14 13:11 ` Mimi Zohar
2009-05-15  0:40 ` James Morris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®