From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Anton Blanchard <anton@samba.org>,
Oleg Nesterov <oleg@redhat.com>,
Zhao Lei <zhaolei@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 2/5] tracing/events: use %pf in workqueue trace events
Date: Mon, 1 Jun 2009 19:17:14 +0200 [thread overview]
Message-ID: <1243876637-6616-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1243876637-6616-1-git-send-email-fweisbec@gmail.com>
From: Anton Blanchard <anton@samba.org>
Using %pf instead of %pF supresses printing of the function offset
which will always be 0.
[ Impact: cleanup workqueue events traces output ]
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
Documentation/trace/workqueue.txt | 6 +++---
include/trace/events/workqueue.h | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/trace/workqueue.txt b/Documentation/trace/workqueue.txt
index 4019a8a..c446b28 100644
--- a/Documentation/trace/workqueue.txt
+++ b/Documentation/trace/workqueue.txt
@@ -107,8 +107,8 @@ worklet_cancel worklet_enqueue worklet_execute workqueue_destruction
# TASK-PID CPU# TIMESTAMP FUNCTION
# | | | | |
-<...>-5627 [000] 4597.858645: worklet_enqueue: thread=ata/0:508 func=ata_pio_task+0x0/0x280 cpu=0
-<...>-508 [000] 4597.858660: worklet_execute: thread=ata/0:508 work=ffff88007e9e67b8 func=ata_pio_task+0x0/0x280
+<...>-5627 [000] 4597.858645: worklet_enqueue: thread=ata/0:508 func=ata_pio_task cpu=0
+<...>-508 [000] 4597.858660: worklet_execute: thread=ata/0:508 work=ffff88007e9e67b8 func=ata_pio_task
<...>-508 [000] 4597.858684: worklet_complete: thread=ata/0:508 work=ffff88007e9e67b8
-<...>-2437 [000] 4597.861259: worklet_cancel: func=ata_pio_task+0x0/0x280
+<...>-2437 [000] 4597.861259: worklet_cancel: func=ata_pio_task
[...]
diff --git a/include/trace/events/workqueue.h b/include/trace/events/workqueue.h
index 49608c7..6cb7833 100644
--- a/include/trace/events/workqueue.h
+++ b/include/trace/events/workqueue.h
@@ -32,7 +32,7 @@ TRACE_EVENT(worklet_enqueue,
__entry->cpu = cpu;
),
- TP_printk("thread=%s:%d func=%pF cpu=%d", __entry->thread_comm,
+ TP_printk("thread=%s:%d func=%pf cpu=%d", __entry->thread_comm,
__entry->thread_pid, __entry->func, __entry->cpu)
);
@@ -63,7 +63,7 @@ TRACE_EVENT(worklet_enqueue_delayed,
__entry->delay = delay;
),
- TP_printk("thread=%s:%d func=%pF cpu=%d delay=%lu",
+ TP_printk("thread=%s:%d func=%pf cpu=%d delay=%lu",
__entry->thread_comm, __entry->thread_pid, __entry->func,
__entry->cpu, __entry->delay)
);
@@ -88,7 +88,7 @@ TRACE_EVENT(worklet_execute,
__entry->func = work->func;
),
- TP_printk("thread=%s:%d work=%p func=%pF", __entry->thread_comm,
+ TP_printk("thread=%s:%d work=%p func=%pf", __entry->thread_comm,
__entry->thread_pid, __entry->work, __entry->func)
);
@@ -128,7 +128,7 @@ TRACE_EVENT(worklet_cancel,
__entry->func = work->func;
),
- TP_printk("func=%pF", __entry->func)
+ TP_printk("func=%pf", __entry->func)
);
/* Trace the creation of one workqueue thread on a cpu */
--
1.6.2.3
next prev parent reply other threads:[~2009-06-01 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 17:17 [PATCH 0/5] tracing/workqueue updates Frederic Weisbecker
2009-06-01 17:17 ` [PATCH 1/5] tracing/workqueue: get rid of searching last executed worklet in probe_worklet_complete() Frederic Weisbecker
2009-06-01 17:17 ` Frederic Weisbecker [this message]
2009-06-01 17:17 ` [PATCH 3/5] tracing/events: rename worklet_execute to worklet_entry and worklet_complete to worklet_exit Frederic Weisbecker
2009-06-01 17:17 ` [PATCH 4/5] tracing/workqueue: fix list header and function name format Frederic Weisbecker
2009-06-01 17:17 ` [PATCH 5/5] tracing/workqueue: cleanup for trace_workqueue.c Frederic Weisbecker
2009-06-01 21:42 ` [PATCH 0/5] tracing/workqueue updates Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243876637-6616-3-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®