* [PATCH] regulator: Report regulator_get() failure in virtual consumer
@ 2009-06-15 19:01 Mark Brown
2009-06-16 9:15 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2009-06-15 19:01 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-kernel, Mark Brown
The core will no longer complain so we should log an error here.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/regulator/virtual.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
index e7db566..e953c18 100644
--- a/drivers/regulator/virtual.c
+++ b/drivers/regulator/virtual.c
@@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
drvdata->regulator = regulator_get(&pdev->dev, reg_id);
if (IS_ERR(drvdata->regulator)) {
ret = PTR_ERR(drvdata->regulator);
+ dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
+ reg_id, ret);
goto err;
}
--
1.6.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: Report regulator_get() failure in virtual consumer
2009-06-15 19:01 [PATCH] regulator: Report regulator_get() failure in virtual consumer Mark Brown
@ 2009-06-16 9:15 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2009-06-16 9:15 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Mon, 2009-06-15 at 20:01 +0100, Mark Brown wrote:
> The core will no longer complain so we should log an error here.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/regulator/virtual.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
> index e7db566..e953c18 100644
> --- a/drivers/regulator/virtual.c
> +++ b/drivers/regulator/virtual.c
> @@ -285,6 +285,8 @@ static int regulator_virtual_consumer_probe(struct platform_device *pdev)
> drvdata->regulator = regulator_get(&pdev->dev, reg_id);
> if (IS_ERR(drvdata->regulator)) {
> ret = PTR_ERR(drvdata->regulator);
> + dev_err(&pdev->dev, "Failed to obtain supply '%s': %d\n",
> + reg_id, ret);
> goto err;
> }
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-16 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-15 19:01 [PATCH] regulator: Report regulator_get() failure in virtual consumer Mark Brown
2009-06-16 9:15 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®