mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: selinux@tycho.nsa.gov, "Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 3/8] SELinux netif.c non trivial fixes.
Date: Wed,  1 Jul 2009 22:32:42 -0700	[thread overview]
Message-ID: <1246512767-2999-4-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1246512767-2999-1-git-send-email-justinmattock@gmail.com>

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

Fix some comments.
---
 security/selinux/netif.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/security/selinux/netif.c b/security/selinux/netif.c
index b4e14bc..dc6dc37 100644
--- a/security/selinux/netif.c
+++ b/security/selinux/netif.c
@@ -71,8 +71,8 @@ static inline struct sel_netif *sel_netif_find(int ifindex)
 	struct sel_netif *netif;
 
 	list_for_each_entry_rcu(netif, &sel_netif_hash[idx], list)
-		/* all of the devices should normally fit in the hash, so we
-		 * optimize for that case */
+		/* All of the devices should normally fit in the hash, so we
+		 * optimize for that case. */
 		if (likely(netif->nsec.ifindex == ifindex))
 			return netif;
 
@@ -152,13 +152,13 @@ static int sel_netif_sid_slow(int ifindex, u32 *sid)
 	struct sel_netif *new = NULL;
 	struct net_device *dev;
 
-	/* NOTE: we always use init's network namespace since we don't
-	 * currently support containers */
+	/* NOTE: We always use init's network namespace since we don't
+	 * currently support containers. */
 
 	dev = dev_get_by_index(&init_net, ifindex);
 	if (unlikely(dev == NULL)) {
 		printk(KERN_WARNING
-		       "SELinux: failure in sel_netif_sid_slow(),"
+		       "SELinux: Failure in sel_netif_sid_slow(),"
 		       " invalid network interface (%d)\n", ifindex);
 		return -ENOENT;
 	}
@@ -189,7 +189,7 @@ out:
 	dev_put(dev);
 	if (unlikely(ret)) {
 		printk(KERN_WARNING
-		       "SELinux: failure in sel_netif_sid_slow(),"
+		       "SELinux: Failure in sel_netif_sid_slow(),"
 		       " unable to determine network interface label (%d)\n",
 		       ifindex);
 		kfree(new);
-- 
1.6.3.2


  parent reply	other threads:[~2009-07-02  5:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02  5:32 SELinux-non-trivial-fixes Justin P. Mattock
2009-07-02  5:32 ` [PATCH 1/8] SELinux avc.c non-trivial fixes Justin P. Mattock
2009-07-02  5:32 ` [PATCH 2/8] SELinux hooks.c non-trivial-fixes Justin P. Mattock
2009-07-02  5:32 ` Justin P. Mattock [this message]
2009-07-02  5:32 ` [PATCH 4/8] SELinux netlabel.c non trivial fixes Justin P. Mattock
2009-07-02  5:32 ` [PATCH 5/8] SELinux netnode.c " Justin P. Mattock
2009-07-02  5:32 ` [PATCH 6/8] SELinux netport.c " Justin P. Mattock
2009-07-02  5:32 ` [PATCH 7/8] SELinux selinuxfs.c " Justin P. Mattock
2009-07-02  5:32 ` [PATCH 8/8] SELinux xfrm.c " Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246512767-2999-4-git-send-email-justinmattock@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®