From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: selinux@tycho.nsa.gov, "Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 5/8] SELinux netnode.c non trivial fixes.
Date: Wed, 1 Jul 2009 22:32:44 -0700 [thread overview]
Message-ID: <1246512767-2999-6-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1246512767-2999-1-git-send-email-justinmattock@gmail.com>
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Fix some comments.
---
security/selinux/netnode.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/security/selinux/netnode.c b/security/selinux/netnode.c
index 7100072..426c41d 100644
--- a/security/selinux/netnode.c
+++ b/security/selinux/netnode.c
@@ -57,11 +57,11 @@ struct sel_netnode {
struct rcu_head rcu;
};
-/* NOTE: we are using a combined hash table for both IPv4 and IPv6, the reason
+/* NOTE: We are using a combined hash table for both IPv4 and IPv6, the reason
* for this is that I suspect most users will not make heavy use of both
* address families at the same time so one table will usually end up wasted,
* if this becomes a problem we can always add a hash table for each address
- * family later */
+ * family later. */
static LIST_HEAD(sel_netnode_list);
static DEFINE_SPINLOCK(sel_netnode_lock);
@@ -94,8 +94,8 @@ static void sel_netnode_free(struct rcu_head *p)
*/
static unsigned int sel_netnode_hashfn_ipv4(__be32 addr)
{
- /* at some point we should determine if the mismatch in byte order
- * affects the hash function dramatically */
+ /* At some point we should determine if the mismatch in byte order
+ * affects the hash function dramatically. */
return (addr & (SEL_NETNODE_HASH_SIZE - 1));
}
@@ -110,9 +110,9 @@ static unsigned int sel_netnode_hashfn_ipv4(__be32 addr)
*/
static unsigned int sel_netnode_hashfn_ipv6(const struct in6_addr *addr)
{
- /* just hash the least significant 32 bits to keep things fast (they
+ /* Just hash the least significant 32 bits to keep things fast (they
* are the most likely to be different anyway), we can revisit this
- * later if needed */
+ * later if needed. */
return (addr->s6_addr32[3] & (SEL_NETNODE_HASH_SIZE - 1));
}
@@ -184,8 +184,8 @@ static void sel_netnode_insert(struct sel_netnode *node)
INIT_RCU_HEAD(&node->rcu);
- /* we need to impose a limit on the growth of the hash table so check
- * this bucket to make sure it is within the specified bounds */
+ /* We need to impose a limit on the growth of the hash table so check
+ * this bucket to make sure it is within the specified bounds. */
list_add_rcu(&node->list, &sel_netnode_hash[idx].list);
if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
struct sel_netnode *tail;
@@ -252,8 +252,8 @@ out:
spin_unlock_bh(&sel_netnode_lock);
if (unlikely(ret)) {
printk(KERN_WARNING
- "SELinux: failure in sel_netnode_sid_slow(),"
- " unable to determine network node label\n");
+ "SELinux: Failure in sel_netnode_sid_slow(),"
+ " unable to determine network node label.\n");
kfree(new);
}
return ret;
--
1.6.3.2
next prev parent reply other threads:[~2009-07-02 5:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 5:32 SELinux-non-trivial-fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 1/8] SELinux avc.c non-trivial fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 2/8] SELinux hooks.c non-trivial-fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 3/8] SELinux netif.c non trivial fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 4/8] SELinux netlabel.c " Justin P. Mattock
2009-07-02 5:32 ` Justin P. Mattock [this message]
2009-07-02 5:32 ` [PATCH 6/8] SELinux netport.c " Justin P. Mattock
2009-07-02 5:32 ` [PATCH 7/8] SELinux selinuxfs.c " Justin P. Mattock
2009-07-02 5:32 ` [PATCH 8/8] SELinux xfrm.c " Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246512767-2999-6-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®