From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: selinux@tycho.nsa.gov, "Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH 4/8] SELinux netlabel.c non trivial fixes.
Date: Wed, 1 Jul 2009 22:32:43 -0700 [thread overview]
Message-ID: <1246512767-2999-5-git-send-email-justinmattock@gmail.com> (raw)
In-Reply-To: <1246512767-2999-1-git-send-email-justinmattock@gmail.com>
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Fix a comment to sound better.
Fix some comments.
---
security/selinux/netlabel.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/security/selinux/netlabel.c b/security/selinux/netlabel.c
index 2e98441..7868ea2 100644
--- a/security/selinux/netlabel.c
+++ b/security/selinux/netlabel.c
@@ -167,7 +167,7 @@ void selinux_netlbl_sk_security_reset(struct sk_security_struct *ssec)
*
* Description:
* Call the NetLabel mechanism to get the security attributes of the given
- * packet and use those attributes to determine the correct context/SID to
+ * packet and use those attributes to determine the correct context/SID to be
* assign to the packet. Returns zero on success, negative values on failure.
*
*/
@@ -216,8 +216,8 @@ int selinux_netlbl_skbuff_setsid(struct sk_buff *skb,
struct netlbl_lsm_secattr *secattr = NULL;
struct sock *sk;
- /* if this is a locally generated packet check to see if it is already
- * being labeled by it's parent socket, if it is just exit */
+ /* If this is a locally generated packet check to see if it is already
+ * being labeled by it's parent socket, if it is just exit. */
sk = skb->sk;
if (sk != NULL) {
struct sk_security_struct *sksec = sk->sk_security;
@@ -444,9 +444,9 @@ int selinux_netlbl_socket_connect(struct sock *sk, struct sockaddr *addr)
local_bh_disable();
bh_lock_sock_nested(sk);
- /* connected sockets are allowed to disconnect when the address family
+ /* Connected sockets are allowed to disconnect when the address family
* is set to AF_UNSPEC, if that is what is happening we want to reset
- * the socket */
+ * the socket. */
if (addr->sa_family == AF_UNSPEC) {
netlbl_sock_delattr(sk);
sksec->nlbl_state = NLBL_REQSKB;
--
1.6.3.2
next prev parent reply other threads:[~2009-07-02 5:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 5:32 SELinux-non-trivial-fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 1/8] SELinux avc.c non-trivial fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 2/8] SELinux hooks.c non-trivial-fixes Justin P. Mattock
2009-07-02 5:32 ` [PATCH 3/8] SELinux netif.c non trivial fixes Justin P. Mattock
2009-07-02 5:32 ` Justin P. Mattock [this message]
2009-07-02 5:32 ` [PATCH 5/8] SELinux netnode.c " Justin P. Mattock
2009-07-02 5:32 ` [PATCH 6/8] SELinux netport.c " Justin P. Mattock
2009-07-02 5:32 ` [PATCH 7/8] SELinux selinuxfs.c " Justin P. Mattock
2009-07-02 5:32 ` [PATCH 8/8] SELinux xfrm.c " Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246512767-2999-5-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®