* [PATCH] fix "no member named 'sect_attrs' of strcut module"
@ 2009-09-04 3:48 Wu Zhangjin
2009-09-04 5:04 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Wu Zhangjin @ 2009-09-04 3:48 UTC (permalink / raw)
To: linux-kernel
Cc: James Bottomley, Rusty Russell, Helge Deller, Linus Torvalds,
Wu Zhangjin
From: Wu Zhangjin <wuzhangjin@gmail.com>
The commit(1b364bf438cf337a3818aee77d68c0713f3e1fc4, "module: workaround
duplicate section names") introduced a condition to avoid null pointer
reference:
- add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+ if (mod->sect_attrs)
+ add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
but sect_attrs is only defined when CONFIG_KALLSYMS enabled, so this
patch is need to fix the following error:
error: 'struct module' has no member named 'sect_attrs'
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
kernel/module.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index eccb561..b4016d1 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2355,8 +2355,10 @@ static noinline struct module *load_module(void __user *umod,
if (err < 0)
goto unlink;
add_sect_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+#ifdef CONFIG_KALLSYMS
if (mod->sect_attrs)
add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
+#endif
/* Get rid of temporary copy */
vfree(hdr);
--
1.6.2.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix "no member named 'sect_attrs' of strcut module"
2009-09-04 3:48 [PATCH] fix "no member named 'sect_attrs' of strcut module" Wu Zhangjin
@ 2009-09-04 5:04 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-09-04 5:04 UTC (permalink / raw)
To: Wu Zhangjin
Cc: linux-kernel, James Bottomley, Rusty Russell, Helge Deller,
Linus Torvalds
* Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
>
> The commit(1b364bf438cf337a3818aee77d68c0713f3e1fc4, "module: workaround
> duplicate section names") introduced a condition to avoid null pointer
> reference:
>
> - add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
> + if (mod->sect_attrs)
> + add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
>
> but sect_attrs is only defined when CONFIG_KALLSYMS enabled, so this
> patch is need to fix the following error:
>
> error: 'struct module' has no member named 'sect_attrs'
>
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
This has been fixed already, see this upstream fix:
ea6bff3: modules: Fix build error in the !CONFIG_KALLSYMS case
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-04 5:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-04 3:48 [PATCH] fix "no member named 'sect_attrs' of strcut module" Wu Zhangjin
2009-09-04 5:04 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®