From: Daniel Walker <dwalker@fifo99.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, Daniel Walker <dwalker@fifo99.com>
Subject: [PATCH 2/5] checkpatch: fix hang in relative indent checking
Date: Mon, 21 Sep 2009 19:14:48 -0700 [thread overview]
Message-ID: <1253585691-10987-2-git-send-email-dwalker@fifo99.com> (raw)
In-Reply-To: <1253585691-10987-1-git-send-email-dwalker@fifo99.com>
I ran this command on v2.6.31 ,
./scripts/checkpatch.pl --file net/decnet/dn_fib.c
which resulted in checkpatch hanging without any output.
The lines that cause the hang are,
#define for_nexthops(fi) { int nhsel; const struct dn_fib_nh *nh;\
for(nhsel = 0, nh = (fi)->fib_nh; nhsel < (fi)->fib_nhs; nh++, nhsel++)
The hang happend in the relative indent checking code. Checkpatch has the
following comment around the relative indent checking block,
# Also ignore a loop construct at the end of a
# preprocessor statement.
Since the line it's hanging on exactly fits the comment it shouldn't even be
checking this line. To resolve this I just prevent the checking like the
comment says should happen.
Signed-off-by: Daniel Walker <dwalker@fifo99.com>
---
scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 09bab22..1c48a6c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1519,7 +1519,7 @@ sub process {
my $cond_ptr = -1;
$continuation = 0;
- while ($cond_ptr != $cond_lines) {
+ while ($check && $cond_ptr != $cond_lines) {
$cond_ptr = $cond_lines;
# If we see an #else/#elif then the code
--
1.5.6.3
next prev parent reply other threads:[~2009-09-22 2:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:14 [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Daniel Walker
2009-09-22 2:14 ` Daniel Walker [this message]
2009-09-22 2:14 ` [PATCH 3/5] checkpatch: add a blacklist Daniel Walker
2009-09-22 2:14 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Daniel Walker
2009-09-22 2:14 ` [PATCH 5/5] checkpatch: fix false EXPORT_SYMBOL warning Daniel Walker
2009-09-30 17:46 ` Andy Whitcroft
2009-10-01 14:28 ` Daniel Walker
2009-10-02 7:39 ` Andy Whitcroft
2009-09-30 17:46 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Andy Whitcroft
2009-10-01 14:26 ` Daniel Walker
2009-10-02 7:43 ` Andy Whitcroft
2009-09-22 6:29 ` [PATCH 3/5] checkpatch: add a blacklist Li Zefan
2009-09-30 15:27 ` Andy Whitcroft
2009-10-01 14:18 ` Daniel Walker
2009-10-06 19:51 ` Steven Rostedt
2009-10-06 20:50 ` Krzysztof Halasa
2009-10-07 3:52 ` Daniel Walker
2009-10-07 10:17 ` Krzysztof Halasa
2009-10-07 14:26 ` Daniel Walker
2009-10-07 14:44 ` Krzysztof Halasa
2009-10-07 14:57 ` Daniel Walker
2009-10-07 15:11 ` Alan Cox
2009-10-07 15:41 ` Daniel Walker
2009-10-07 15:52 ` Alan Cox
2009-10-07 16:11 ` Daniel Walker
2009-10-07 15:08 ` Steven Rostedt
2009-10-07 15:38 ` Daniel Walker
2009-10-07 21:30 ` Krzysztof Halasa
2009-10-07 21:58 ` Daniel Walker
2009-09-30 15:24 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Andy Whitcroft
2009-09-30 17:46 ` [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Andy Whitcroft
2009-10-01 14:20 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253585691-10987-2-git-send-email-dwalker@fifo99.com \
--to=dwalker@fifo99.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome