From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Krzysztof Halasa <khc@pm.waw.pl>,
Andy Whitcroft <apw@canonical.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist
Date: Wed, 7 Oct 2009 16:11:07 +0100 [thread overview]
Message-ID: <20091007161107.72b4031b@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1254927438.18167.275.camel@desktop>
> Right it's a tool .. However, you should use it and you should follow
> it. If for some reason you disagree with the tool you have to give at
> least an arguable reason why, not just "It's a guide", "I don't like the
> coding style." etc..
Those are perfectly good reasons.
> In the case of Steven's code he has an arguable reason why he's not
> following checkpatch..
Checkpatch is not very bright, it has no understanding of style beyond
playing with pattern regexps. It's a rather dim tool that helps people
get work done. (*)
When used at random to "validate" submissions to the kernel the result is
about as useful as a square wheel on a hovercraft.
Alan
(*) or as some would have it a rather dim tool used by even dimmer tools
to make noise on kernel list.
next prev parent reply other threads:[~2009-10-07 15:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:14 [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Daniel Walker
2009-09-22 2:14 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Daniel Walker
2009-09-22 2:14 ` [PATCH 3/5] checkpatch: add a blacklist Daniel Walker
2009-09-22 2:14 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Daniel Walker
2009-09-22 2:14 ` [PATCH 5/5] checkpatch: fix false EXPORT_SYMBOL warning Daniel Walker
2009-09-30 17:46 ` Andy Whitcroft
2009-10-01 14:28 ` Daniel Walker
2009-10-02 7:39 ` Andy Whitcroft
2009-09-30 17:46 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Andy Whitcroft
2009-10-01 14:26 ` Daniel Walker
2009-10-02 7:43 ` Andy Whitcroft
2009-09-22 6:29 ` [PATCH 3/5] checkpatch: add a blacklist Li Zefan
2009-09-30 15:27 ` Andy Whitcroft
2009-10-01 14:18 ` Daniel Walker
2009-10-06 19:51 ` Steven Rostedt
2009-10-06 20:50 ` Krzysztof Halasa
2009-10-07 3:52 ` Daniel Walker
2009-10-07 10:17 ` Krzysztof Halasa
2009-10-07 14:26 ` Daniel Walker
2009-10-07 14:44 ` Krzysztof Halasa
2009-10-07 14:57 ` Daniel Walker
2009-10-07 15:11 ` Alan Cox [this message]
2009-10-07 15:41 ` Daniel Walker
2009-10-07 15:52 ` Alan Cox
2009-10-07 16:11 ` Daniel Walker
2009-10-07 15:08 ` Steven Rostedt
2009-10-07 15:38 ` Daniel Walker
2009-10-07 21:30 ` Krzysztof Halasa
2009-10-07 21:58 ` Daniel Walker
2009-09-30 15:24 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Andy Whitcroft
2009-09-30 17:46 ` [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Andy Whitcroft
2009-10-01 14:20 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091007161107.72b4031b@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwalker@fifo99.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®