From: Catalin Marinas <catalin.marinas@arm.com>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: Leaks in trace reported by kmemleak
Date: Mon, 19 Oct 2009 14:20:22 +0100 [thread overview]
Message-ID: <1255958422.31096.33.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <1255953605.31096.26.camel@pc1117.cambridge.arm.com>
On Mon, 2009-10-19 at 13:00 +0100, Catalin Marinas wrote:
> On Mon, 2009-10-19 at 11:15 +0200, Zdenek Kabelac wrote:
> > What is however interesting is the false positive leak for
> > dma_debug_init(). Which is sometimes listed and sometimes not - the
> > memory is allocated just once in the code during boot, so it's strange
> > that pointers to that area are sometimes out of kmemleak scan.
>
> A workaround I had in the past was to not report an object unless it was
> found as a leak in two consecutive scans. I should probably reinstate
> this feature (could be optimised to use a second prio_tree containing
> only objects found as leaks).
OK, I re-added a form of this to the kmemleak.git tree and simplified
the scanning logic (meant initially to reduce the false positives). Now,
for an object to be reported, it needs to be found as leak during two
consecutive scans (this works around pointer moving from a structure to
a different one which was already scanned).
If you have time, could you please give it a try and see whether you
still get transient false positives?
As for the patch showing where an object is referred from, I think it's
still useful for debugging possible false negatives, so I'll leave it
in.
Thanks.
--
Catalin
next prev parent reply other threads:[~2009-10-19 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 8:59 Zdenek Kabelac
2009-10-15 9:46 ` Li Zefan
2009-10-15 11:22 ` Catalin Marinas
2009-10-16 7:45 ` Zdenek Kabelac
2009-10-16 10:57 ` Catalin Marinas
2009-10-16 13:32 ` Zdenek Kabelac
2009-10-16 14:11 ` Catalin Marinas
2009-10-16 14:28 ` Zdenek Kabelac
2009-10-16 15:07 ` Zdenek Kabelac
2009-10-16 15:31 ` Catalin Marinas
2009-10-16 16:41 ` Catalin Marinas
2009-10-19 9:15 ` Zdenek Kabelac
2009-10-19 12:00 ` Catalin Marinas
2009-10-19 13:20 ` Catalin Marinas [this message]
2009-10-20 9:58 ` Zdenek Kabelac
2009-10-20 17:03 ` Catalin Marinas
2009-10-22 13:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255958422.31096.33.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®