mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: Leaks in trace reported by kmemleak
Date: Thu, 22 Oct 2009 14:09:28 +0100	[thread overview]
Message-ID: <1256216968.8608.21.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <c4e36d110910200258q7c1d6b4uf74b6d365ffb3f40@mail.gmail.com>

Hi Zdenek,

On Tue, 2009-10-20 at 11:58 +0200, Zdenek Kabelac wrote:
> I've tested your git with updates - and here is my experience:
> 
> I'm still able to get FP leaks printed even with the print of
> more-then-once appearanc.

I updated the kmemleak.git tree and in my tests it reduced the false
positives significantly. I dropped the two-pass scanning patch and I
added a new one which checks whether objects were modified since the
previous leak suspicion and only report them if unmodified (using
csum_partial for checksum calculation). This works well with linked
lists since list deletion modifies the prev/next pointers of those left
in the list (like in the debug_objects case).

> Also jiffies might be eventually more readable via data/time - but
> this can be preprocessed via script.

Jiffies is still useful to ensure it's the same object or a new one
allocated in the same function (and possibly false positive). I added
another bit of information - the age of an object in seconds.msecs.

-- 
Catalin


      parent reply	other threads:[~2009-10-22 13:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15  8:59 Zdenek Kabelac
2009-10-15  9:46 ` Li Zefan
2009-10-15 11:22   ` Catalin Marinas
2009-10-16  7:45     ` Zdenek Kabelac
2009-10-16 10:57       ` Catalin Marinas
2009-10-16 13:32         ` Zdenek Kabelac
2009-10-16 14:11           ` Catalin Marinas
2009-10-16 14:28             ` Zdenek Kabelac
2009-10-16 15:07               ` Zdenek Kabelac
2009-10-16 15:31                 ` Catalin Marinas
2009-10-16 16:41                 ` Catalin Marinas
2009-10-19  9:15                   ` Zdenek Kabelac
2009-10-19 12:00                     ` Catalin Marinas
2009-10-19 13:20                       ` Catalin Marinas
2009-10-20  9:58                         ` Zdenek Kabelac
2009-10-20 17:03                           ` Catalin Marinas
2009-10-22 13:09                           ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256216968.8608.21.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=zdenek.kabelac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®