* [PATCH] parport_pc.c: Use correct length in strncmp
@ 2009-11-10 3:51 Joe Perches
2009-11-10 10:25 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2009-11-10 3:51 UTC (permalink / raw)
To: Alan Cox; +Cc: LKML
Signed-off-by: Joe Perches <joe@perches.com>
diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
index 2597145..ad113b0 100644
--- a/drivers/parport/parport_pc.c
+++ b/drivers/parport/parport_pc.c
@@ -3403,7 +3403,7 @@ static int __init parport_parse_param(const char *s, int *val,
*val = automatic;
else if (!strncmp(s, "none", 4))
*val = none;
- else if (nofifo && !strncmp(s, "nofifo", 4))
+ else if (nofifo && !strncmp(s, "nofifo", 6))
*val = nofifo;
else {
char *ep;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] parport_pc.c: Use correct length in strncmp
2009-11-10 3:51 [PATCH] parport_pc.c: Use correct length in strncmp Joe Perches
@ 2009-11-10 10:25 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2009-11-10 10:25 UTC (permalink / raw)
To: Joe Perches; +Cc: Alan Cox, LKML
On Mon, 09 Nov 2009 19:51:23 -0800
Joe Perches <joe@perches.com> wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/drivers/parport/parport_pc.c b/drivers/parport/parport_pc.c
> index 2597145..ad113b0 100644
> --- a/drivers/parport/parport_pc.c
> +++ b/drivers/parport/parport_pc.c
> @@ -3403,7 +3403,7 @@ static int __init parport_parse_param(const char *s, int *val,
> *val = automatic;
> else if (!strncmp(s, "none", 4))
> *val = none;
> - else if (nofifo && !strncmp(s, "nofifo", 4))
> + else if (nofifo && !strncmp(s, "nofifo", 6))
> *val = nofifo;
I just hope nobody is booting with =nofif due to a typo ;)
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-10 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-10 3:51 [PATCH] parport_pc.c: Use correct length in strncmp Joe Perches
2009-11-10 10:25 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®