From: Johannes Berg <johannes@sipsolutions.net>
To: Andreas Schwab <schwab@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.32] ftrace: fix event format export
Date: Fri, 13 Nov 2009 14:29:26 +0100 [thread overview]
Message-ID: <1258118966.6167.21.camel@johannes.local> (raw)
In-Reply-To: <m3y6mazhij.fsf@hase.home>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Fri, 2009-11-13 at 14:22 +0100, Andreas Schwab wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > --- wireless-testing.orig/include/trace/ftrace.h 2009-11-13 13:15:21.000000000 +0100
> > +++ wireless-testing/include/trace/ftrace.h 2009-11-13 13:34:03.000000000 +0100
> > @@ -159,7 +159,7 @@
> > #undef __get_str
> >
> > #undef TP_printk
> > -#define TP_printk(fmt, args...) "%s, %s\n", #fmt, __stringify(args)
> > +#define TP_printk(fmt, args...) "\"%s\", %s\n", fmt, __stringify(args)
>
> Would using __stringify(fmt) work? If there are double quote characters
> in fmt your solution would produce output that is ambiguous.
No, for say
#define FOO_FMT "foo:%d"
and using
FOO_FMT ", %d"
that would give
""%s", %d"
instead of
"%s, %d"
However, isn't it already ambiguous that way? I fail to see why %s, #fmt
would preserve inside " properly.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-11-13 13:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 12:37 Johannes Berg
2009-11-13 13:22 ` Andreas Schwab
2009-11-13 13:29 ` Johannes Berg [this message]
2009-11-13 13:32 ` Johannes Berg
2009-11-13 22:40 ` Ingo Molnar
2009-11-13 23:28 ` Steven Rostedt
2009-11-14 9:21 ` Johannes Berg
2009-11-14 4:12 ` [PATCH][GIT PULL][v2.6.32] tracing: Fix " Steven Rostedt
2009-11-14 9:39 ` Ingo Molnar
2009-11-14 10:18 ` [tip:tracing/urgent] " tip-bot for Johannes Berg
2009-12-03 14:41 ` Steven Rostedt
2009-12-03 14:55 ` Ingo Molnar
2009-12-06 16:19 ` Johannes Berg
2009-12-06 17:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258118966.6167.21.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®