mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Fr??d??ric Weisbecker <fweisbec@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.32] ftrace: fix event format export
Date: Fri, 13 Nov 2009 18:28:29 -0500	[thread overview]
Message-ID: <1258154909.22249.211.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20091113224009.GB23942@elte.hu>

On Fri, 2009-11-13 at 23:40 +0100, Ingo Molnar wrote:
> ( extended the Cc:s. Please try to Cc: people you think would be 
>   interested in your patches. )

Thanks Ingo.

> 
> * Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> > For some reason the export of the event print
> > format to userspace uses '#fmt' which breaks
> > if the format string is anything but a plain
> > string, for example if it is built with macros
> > then the macro names are exported instead of
> > their contents.
> > 
> > Use
> > 	"\"%s\"", fmt
> > instead of
> > 	"%s", #fmt
> > to export the string and not the way it is built.

Is there any examples of this currently in the kernel? If so could you
show that in the changlog.

But other than that, the change looks good.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---



  reply	other threads:[~2009-11-13 23:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 12:37 Johannes Berg
2009-11-13 13:22 ` Andreas Schwab
2009-11-13 13:29   ` Johannes Berg
2009-11-13 13:32     ` Johannes Berg
2009-11-13 22:40 ` Ingo Molnar
2009-11-13 23:28   ` Steven Rostedt [this message]
2009-11-14  9:21     ` Johannes Berg
2009-11-14  4:12   ` [PATCH][GIT PULL][v2.6.32] tracing: Fix " Steven Rostedt
2009-11-14  9:39     ` Ingo Molnar
2009-11-14 10:18   ` [tip:tracing/urgent] " tip-bot for Johannes Berg
2009-12-03 14:41     ` Steven Rostedt
2009-12-03 14:55       ` Ingo Molnar
2009-12-06 16:19         ` Johannes Berg
2009-12-06 17:11           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258154909.22249.211.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®