Re: [PATCH 2.6.32] ftrace: fix event format export

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

On Fri, 2009-11-13 at 18:28 -0500, Steven Rostedt wrote:

> > > Use
> > > 	"\"%s\"", fmt
> > > instead of
> > > 	"%s", #fmt
> > > to export the string and not the way it is built.
> 
> Is there any examples of this currently in the kernel? If so could you
> show that in the changlog.

net/mac80211/driver-trace.h has some that are exported really badly and
both trace-cmd and perf fall over on them.

Incidentally, the kvm_mmu ones are also weird, but I'm not sure they can
be fixed up properly.

Do you think Andreas's objection to the now-missing escaping of " and \
is a problem, or should we either fix the parsers to parse the string
backward from REC stuff, or fix the routine that outputs them to
userspace to quote " and \?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]