mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: alacrityvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] vbus: fix lots of sparse "dubious signed bitfield" warnings
Date: Tue,  8 Dec 2009 12:57:30 -0800	[thread overview]
Message-ID: <1260305854-31472-2-git-send-email-iws@ovro.caltech.edu> (raw)
In-Reply-To: <1260305854-31472-1-git-send-email-iws@ovro.caltech.edu>

The sparse utility gave tons of warnings about signed bitfields. A simple
inspection shows that they are all used as booleans, so convert them to the
correct type.

Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
---
 drivers/vbus/pci-bridge.c |    2 +-
 include/linux/ioq.h       |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/vbus/pci-bridge.c b/drivers/vbus/pci-bridge.c
index 9e37df1..aa683ae 100644
--- a/drivers/vbus/pci-bridge.c
+++ b/drivers/vbus/pci-bridge.c
@@ -43,7 +43,7 @@ struct vbus_pci {
 	struct vbus_pci_regs     *regs;
 	struct vbus_pci_signals  *signals;
 	int                       irq;
-	int                       enabled:1;
+	bool                      enabled;
 	struct {
 		struct dentry    *fs;
 		int               events;
diff --git a/include/linux/ioq.h b/include/linux/ioq.h
index eba1021..f04dfb4 100644
--- a/include/linux/ioq.h
+++ b/include/linux/ioq.h
@@ -112,9 +112,9 @@ struct ioq_iterator {
 	struct ioq_ring_idx   *idx;
 	u32                    pos;
 	struct ioq_ring_desc  *desc;
-	int                    update:1;
-	int                    dualidx:1;
-	int                    flipowner:1;
+	bool                   update;
+	bool                   dualidx;
+	bool                   flipowner;
 };
 
 struct ioq_notifier {
-- 
1.5.4.3


  reply	other threads:[~2009-12-08 20:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 20:57 alacrityvm-next: clearly specify ioq endianness Ira W. Snyder
2009-12-08 20:57 ` Ira W. Snyder [this message]
2009-12-08 20:57 ` [PATCH] vbus: pci-bridge: fix sparse warnings Ira W. Snyder
2009-12-08 20:57 ` [PATCH] vbus-enet: " Ira W. Snyder
2009-12-08 20:57 ` [PATCH] shm_signal: clearly specify endianness Ira W. Snyder
2009-12-08 20:57 ` [PATCH] ioq: " Ira W. Snyder
2009-12-09 18:17 ` [Alacrityvm-devel] alacrityvm-next: clearly specify ioq endianness Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260305854-31472-2-git-send-email-iws@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=alacrityvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®