mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: alacrityvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] vbus-enet: fix sparse warnings
Date: Tue,  8 Dec 2009 12:57:32 -0800	[thread overview]
Message-ID: <1260305854-31472-4-git-send-email-iws@ovro.caltech.edu> (raw)
In-Reply-To: <1260305854-31472-1-git-send-email-iws@ovro.caltech.edu>

Fix the following sparse warnings:
drivers/net/vbus-enet.c:411:9: warning: Using plain integer as NULL pointer
drivers/net/vbus-enet.c:1250:24: warning: Using plain integer as NULL pointer
drivers/net/vbus-enet.c:1326:24: warning: Using plain integer as NULL pointer

Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
---
 drivers/net/vbus-enet.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vbus-enet.c b/drivers/net/vbus-enet.c
index 4e9ecac..8232215 100644
--- a/drivers/net/vbus-enet.c
+++ b/drivers/net/vbus-enet.c
@@ -408,7 +408,7 @@ tx_setup(struct vbus_enet_priv *priv)
 		priv->pmtd.pool = pool;
 
 		ret = dev->ops->shm(dev, NULL, shmid, 0, pool, poollen,
-				    0, NULL, 0);
+				    NULL, NULL, 0);
 		BUG_ON(ret < 0);
 	}
 
@@ -1239,7 +1239,7 @@ vbus_enet_evq_negcap(struct vbus_enet_priv *priv, unsigned long count)
 		priv->evq.pool = pool;
 
 		ret = dev->ops->shm(dev, NULL, query.dpid, 0,
-				    pool, poollen, 0, NULL, 0);
+				    pool, poollen, NULL, NULL, 0);
 		if (ret < 0)
 			return ret;
 
@@ -1315,7 +1315,7 @@ vbus_enet_l4ro_negcap(struct vbus_enet_priv *priv, unsigned long count)
 		 * pre-mapped descriptor pool
 		 */
 		ret = dev->ops->shm(dev, NULL, query.dpid, 0,
-				    pool, poollen, 0, NULL, 0);
+				    pool, poollen, NULL, NULL, 0);
 		if (ret < 0) {
 			printk(KERN_ERR "Error registering L4RO pool: %d\n",
 			       ret);
-- 
1.5.4.3


  parent reply	other threads:[~2009-12-08 20:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 20:57 alacrityvm-next: clearly specify ioq endianness Ira W. Snyder
2009-12-08 20:57 ` [PATCH] vbus: fix lots of sparse "dubious signed bitfield" warnings Ira W. Snyder
2009-12-08 20:57 ` [PATCH] vbus: pci-bridge: fix sparse warnings Ira W. Snyder
2009-12-08 20:57 ` Ira W. Snyder [this message]
2009-12-08 20:57 ` [PATCH] shm_signal: clearly specify endianness Ira W. Snyder
2009-12-08 20:57 ` [PATCH] ioq: " Ira W. Snyder
2009-12-09 18:17 ` [Alacrityvm-devel] alacrityvm-next: clearly specify ioq endianness Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260305854-31472-4-git-send-email-iws@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=alacrityvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®