From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: alacrityvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] vbus: pci-bridge: fix sparse warnings
Date: Tue, 8 Dec 2009 12:57:31 -0800 [thread overview]
Message-ID: <1260305854-31472-3-git-send-email-iws@ovro.caltech.edu> (raw)
In-Reply-To: <1260305854-31472-1-git-send-email-iws@ovro.caltech.edu>
The sparse tool caught many missing static declarations. Add them.
There are still many address space errors, but I'm unsure about the best
way to fix these.
Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
---
drivers/vbus/pci-bridge.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/vbus/pci-bridge.c b/drivers/vbus/pci-bridge.c
index aa683ae..078b8f4 100644
--- a/drivers/vbus/pci-bridge.c
+++ b/drivers/vbus/pci-bridge.c
@@ -66,7 +66,7 @@ struct vbus_pci_device {
struct work_struct drop;
};
-DEFINE_PER_CPU(struct vbus_pci_fastcall_desc, vbus_pci_percpu_fastcall)
+static DEFINE_PER_CPU(struct vbus_pci_fastcall_desc, vbus_pci_percpu_fastcall)
____cacheline_aligned;
/*
@@ -123,7 +123,7 @@ vbus_pci_buscall(unsigned long nr, void *data, unsigned long len)
return ret;
}
-struct vbus_pci_device *
+static struct vbus_pci_device *
to_dev(struct vbus_device_proxy *vdev)
{
return container_of(vdev, struct vbus_pci_device, vdev);
@@ -412,7 +412,7 @@ vbus_pci_device_release(struct vbus_device_proxy *vdev)
kfree(_dev);
}
-struct vbus_device_proxy_ops vbus_pci_device_ops = {
+static struct vbus_device_proxy_ops vbus_pci_device_ops = {
.open = vbus_pci_device_open,
.close = vbus_pci_device_close,
.shm = vbus_pci_device_shm,
@@ -667,7 +667,7 @@ static struct ioq_notifier eventq_notifier = {
};
/* Injected whenever the host issues an ioq_signal() on the eventq */
-irqreturn_t
+static irqreturn_t
eventq_intr(int irq, void *dev)
{
vbus_pci.stats.qnotify++;
@@ -995,7 +995,7 @@ static struct pci_driver vbus_pci_driver = {
.remove = vbus_pci_remove,
};
-int __init
+static int __init
vbus_pci_init(void)
{
memset(&vbus_pci, 0, sizeof(vbus_pci));
--
1.5.4.3
next prev parent reply other threads:[~2009-12-08 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 20:57 alacrityvm-next: clearly specify ioq endianness Ira W. Snyder
2009-12-08 20:57 ` [PATCH] vbus: fix lots of sparse "dubious signed bitfield" warnings Ira W. Snyder
2009-12-08 20:57 ` Ira W. Snyder [this message]
2009-12-08 20:57 ` [PATCH] vbus-enet: fix sparse warnings Ira W. Snyder
2009-12-08 20:57 ` [PATCH] shm_signal: clearly specify endianness Ira W. Snyder
2009-12-08 20:57 ` [PATCH] ioq: " Ira W. Snyder
2009-12-09 18:17 ` [Alacrityvm-devel] alacrityvm-next: clearly specify ioq endianness Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260305854-31472-3-git-send-email-iws@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=alacrityvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®