From: Corrado Zoccolo <czoccolo@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
Jeff Moyer <jmoyer@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Shaohua Li <shaohua.li@intel.com>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
Corrado Zoccolo <czoccolo@gmail.com>
Subject: [PATCH] cfq-iosched: non-rot devices do not need queue merging
Date: Wed, 30 Dec 2009 13:10:04 +0100 [thread overview]
Message-ID: <1262175004-2132-1-git-send-email-czoccolo@gmail.com> (raw)
Non rotational devices' performances are not affected by
distance of requests, so there is no point in having overhead
to merge queues of nearby requests.
Signed-off-by: Corrado Zoccolo <czoccolo@gmail.com>
---
block/cfq-iosched.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 918c7fd..01bb0f3 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -1268,7 +1268,8 @@ static void cfq_prio_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq)
return;
if (!cfqq->next_rq)
return;
-
+ if (blk_queue_nonrot(cfqd->queue))
+ return;
cfqq->p_root = &cfqd->prio_trees[cfqq->org_ioprio];
__cfqq = cfq_prio_tree_lookup(cfqd, cfqq->p_root,
blk_rq_pos(cfqq->next_rq), &parent, &p);
@@ -1689,7 +1690,7 @@ static struct cfq_queue *cfqq_close(struct cfq_data *cfqd,
struct cfq_queue *__cfqq;
sector_t sector = cfqd->last_position;
- if (RB_EMPTY_ROOT(root))
+ if (RB_EMPTY_ROOT(root) || blk_queue_nonrot(cfqd->queue))
return NULL;
/*
--
1.6.4.4
next reply other threads:[~2009-12-30 12:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 12:10 Corrado Zoccolo [this message]
2009-12-30 18:45 ` Jens Axboe
2009-12-30 20:31 ` Corrado Zoccolo
2009-12-30 21:11 ` Jens Axboe
2009-12-30 21:21 ` Corrado Zoccolo
2009-12-30 21:34 ` Jens Axboe
2009-12-30 22:22 ` [PATCH] cfq-iosched: non-rot devices do not need read " Corrado Zoccolo
2010-01-04 14:47 ` Vivek Goyal
2010-01-04 16:36 ` Corrado Zoccolo
2010-01-04 16:51 ` Jeff Moyer
2010-01-04 18:32 ` Vivek Goyal
2010-01-04 18:37 ` Corrado Zoccolo
2010-01-04 18:51 ` Vivek Goyal
2010-01-04 19:04 ` Jeff Moyer
2010-01-04 20:37 ` Corrado Zoccolo
2010-01-05 14:58 ` Jeff Moyer
2010-01-05 15:13 ` Vivek Goyal
2010-01-05 21:19 ` Jeff Moyer
2010-01-05 21:48 ` Corrado Zoccolo
2010-01-07 10:56 ` Kirill Afonshin
2010-01-07 13:38 ` Corrado Zoccolo
2010-01-07 14:36 ` Vivek Goyal
2010-01-07 17:00 ` Corrado Zoccolo
2010-01-07 18:37 ` Vivek Goyal
2010-01-07 20:16 ` Corrado Zoccolo
2010-01-08 18:53 ` Vivek Goyal
2010-01-10 12:55 ` Corrado Zoccolo
2010-01-10 21:04 ` [PATCH] cfq-iosched: NCQ SSDs " Corrado Zoccolo
2010-01-10 21:08 ` Corrado Zoccolo
2010-01-11 11:25 ` Jeff Garzik
2010-01-11 12:26 ` Corrado Zoccolo
2010-01-11 13:13 ` Jens Axboe
2010-01-11 13:18 ` Jeff Garzik
2010-01-11 13:24 ` Jens Axboe
2010-01-11 14:53 ` Corrado Zoccolo
2010-01-11 16:44 ` Vivek Goyal
2010-01-11 17:00 ` Corrado Zoccolo
2010-01-11 17:07 ` Vivek Goyal
2010-01-11 19:05 ` Corrado Zoccolo
2010-01-11 17:11 ` Vivek Goyal
2010-01-11 19:09 ` Corrado Zoccolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262175004-2132-1-git-send-email-czoccolo@gmail.com \
--to=czoccolo@gmail.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=jens.axboe@oracle.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome