From: Alexander Beregalov <a.beregalov@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
Armin Schindler <mac@melware.de>
Subject: [PATCH 3/4] ISDN: hysdn: avoid NULL pointer dereference
Date: Thu, 7 Jan 2010 04:48:40 +0300 [thread overview]
Message-ID: <1262828921-29517-3-git-send-email-a.beregalov@gmail.com> (raw)
In-Reply-To: <1262828921-29517-2-git-send-email-a.beregalov@gmail.com>
Assign dev only if lp is not NULL.
Cc: Armin Schindler <mac@melware.de>
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/isdn/hysdn/hysdn_net.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hysdn/hysdn_net.c b/drivers/isdn/hysdn/hysdn_net.c
index 72eb926..feec8d8 100644
--- a/drivers/isdn/hysdn/hysdn_net.c
+++ b/drivers/isdn/hysdn/hysdn_net.c
@@ -187,12 +187,13 @@ void
hysdn_rx_netpkt(hysdn_card * card, unsigned char *buf, unsigned short len)
{
struct net_local *lp = card->netif;
- struct net_device *dev = lp->dev;
+ struct net_device *dev;
struct sk_buff *skb;
if (!lp)
return; /* non existing device */
+ dev = lp->dev;
dev->stats.rx_bytes += len;
skb = dev_alloc_skb(len);
--
1.6.6
next prev parent reply other threads:[~2010-01-07 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 1:48 [PATCH 1/4] mtd: mxc_nand: " Alexander Beregalov
2010-01-07 1:48 ` [PATCH 2/4] SCSI: pm8001: " Alexander Beregalov
2010-01-07 1:48 ` Alexander Beregalov [this message]
2010-01-07 1:48 ` [PATCH 4/4] uml: line.c: " Alexander Beregalov
2010-01-07 4:32 ` Jeff Dike
2010-01-07 15:56 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262828921-29517-3-git-send-email-a.beregalov@gmail.com \
--to=a.beregalov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®