From: Jeff Dike <jdike@addtoit.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference
Date: Wed, 6 Jan 2010 23:32:41 -0500 [thread overview]
Message-ID: <20100107043241.GA19313@c2.user-mode-linux.org> (raw)
In-Reply-To: <1262828921-29517-4-git-send-email-a.beregalov@gmail.com>
On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
> Assign tty only if line is not NULL.
> if (line)
> + tty = line->tty;
> chan_interrupt(&line->chan_list, &line->task, tty, irq);
> return IRQ_HANDLED;
Even if the thinking is correct, aren't you missing some braces?
Jeff
next prev parent reply other threads:[~2010-01-07 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 1:48 [PATCH 1/4] mtd: mxc_nand: " Alexander Beregalov
2010-01-07 1:48 ` [PATCH 2/4] SCSI: pm8001: " Alexander Beregalov
2010-01-07 1:48 ` [PATCH 3/4] ISDN: hysdn: " Alexander Beregalov
2010-01-07 1:48 ` [PATCH 4/4] uml: line.c: " Alexander Beregalov
2010-01-07 4:32 ` Jeff Dike [this message]
2010-01-07 15:56 ` Alexander Beregalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107043241.GA19313@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=a.beregalov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome