mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Beregalov <a.beregalov@gmail.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference
Date: Thu, 7 Jan 2010 18:56:51 +0300	[thread overview]
Message-ID: <a4423d671001070756u2c6eb8f3p12bf3681b96ba342@mail.gmail.com> (raw)
In-Reply-To: <20100107043241.GA19313@c2.user-mode-linux.org>

2010/1/7 Jeff Dike <jdike@addtoit.com>:
> On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
>> Assign tty only if line is not NULL.
>
>>       if (line)
>> +             tty = line->tty;
>>               chan_interrupt(&line->chan_list, &line->task, tty, irq);
>>       return IRQ_HANDLED;
>
> Even if the thinking is correct, aren't you missing some braces?

Oops, sorry, I will send another version.

      reply	other threads:[~2010-01-07 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07  1:48 [PATCH 1/4] mtd: mxc_nand: " Alexander Beregalov
2010-01-07  1:48 ` [PATCH 2/4] SCSI: pm8001: " Alexander Beregalov
2010-01-07  1:48   ` [PATCH 3/4] ISDN: hysdn: " Alexander Beregalov
2010-01-07  1:48     ` [PATCH 4/4] uml: line.c: " Alexander Beregalov
2010-01-07  4:32       ` Jeff Dike
2010-01-07 15:56         ` Alexander Beregalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4423d671001070756u2c6eb8f3p12bf3681b96ba342@mail.gmail.com \
    --to=a.beregalov@gmail.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®