mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu,
	Jason Wessel <jason.wessel@windriver.com>,
	David Airlie <airlied@linux.ie>
Subject: [PATCH 34/40] i915: when kgdb is active display compression should be off
Date: Thu, 14 Jan 2010 08:59:30 -0600	[thread overview]
Message-ID: <1263481176-1897-35-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1263481176-1897-1-git-send-email-jason.wessel@windriver.com>

If the HW compression is left on, the call backs from the HW will
crash the kernel.  The only time this code is called is when kernel
mode setting is in use with kgdb and the kdb shell.

The atomic display pipe handler callback will reset everything when
kgdb restores kernel to the run state.

CC: David Airlie <airlied@linux.ie>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 drivers/gpu/drm/i915/intel_display.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d54df76..11beb0f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1146,6 +1146,10 @@ static void intel_update_fbc(struct drm_crtc *crtc,
 		goto out_disable;
 	}
 
+	/* If the kernel debugger is active, always disable compression */
+	if (in_dbg_master())
+		goto out_disable;
+
 	if (dev_priv->display.fbc_enabled(crtc)) {
 		/* We can re-enable it in this case, but need to update pitch */
 		if (fb->pitch > dev_priv->cfb_pitch)
-- 
1.6.3.1.9.g95405b


  parent reply	other threads:[~2010-01-14 15:01 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 14:58 [PATCH 0/40] kgdb, kdb and atomic kernel modesetting series Jason Wessel
2010-01-14 14:58 ` [PATCH 01/40] softlockup: add sched_clock_tick() to avoid kernel warning on kgdb resume Jason Wessel
2010-01-14 14:58 ` [PATCH 02/40] x86,hw_breakpoint,kgdb: kgdb to use hw_breakpoint API Jason Wessel
2010-01-14 14:58 ` [PATCH 03/40] Move kernel/kgdb.c to kernel/debug/debug_core.c Jason Wessel
2010-01-14 14:59 ` [PATCH 04/40] Separate the gdbstub from the debug core Jason Wessel
2010-01-14 14:59 ` [PATCH 05/40] kgdb: eliminate kgdb_wait(), all cpus enter the same way Jason Wessel
2010-01-14 14:59 ` [PATCH 06/40] kgdb,sparc: Add in kgdb_arch_set_pc for sparc Jason Wessel
2010-01-14 14:59 ` [PATCH 07/40] kgdb,sh: update superh kgdb exception handling Jason Wessel
2010-01-14 14:59 ` [PATCH 08/40] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin Jason Wessel
2010-01-14 14:59 ` [PATCH 09/40] kdb: core for kgdb back end (1 of 2) Jason Wessel
2010-01-14 14:59 ` [PATCH 10/40] kdb: core for kgdb back end (2 " Jason Wessel
2010-01-14 14:59 ` [PATCH 11/40] kgdb: core changes to support kdb Jason Wessel
2010-01-14 14:59 ` [PATCH 12/40] kgdb,8250,pl011: Return immediately from console poll Jason Wessel
2010-01-14 14:59 ` [PATCH 13/40] sh,sh-sci: Use NO_POLL_CHAR in the SCIF polled console code Jason Wessel
2010-01-14 14:59 ` [PATCH 14/40] sparc,sunzilog: Add console polling support for sunzilog serial driver Jason Wessel
2010-01-14 14:59 ` [PATCH 15/40] kgdb: gdb "monitor" -> kdb passthrough Jason Wessel
2010-01-14 14:59 ` [PATCH 16/40] kgdboc,keyboard: Keyboard driver for kdb with kgdb Jason Wessel
2010-01-14 14:59 ` [PATCH 17/40] kgdb,docs: Update the kgdb docs to include kdb Jason Wessel
2010-01-14 14:59 ` [PATCH 18/40] kgdb: remove post_primary_code references Jason Wessel
2010-01-14 14:59 ` [PATCH 19/40] x86,kgdb: Add low level debug hook Jason Wessel
2010-01-14 14:59 ` [PATCH 20/40] arm,kgdb: Add hook to catch an oops with debugger Jason Wessel
2010-01-14 17:48   ` Russell King - ARM Linux
2010-01-14 18:57     ` Jason Wessel
2010-01-14 20:29     ` Jason Wessel
2010-01-14 20:46       ` Russell King - ARM Linux
2010-01-18 14:30         ` Jason Wessel
2010-01-20 16:03           ` Russell King - ARM Linux
2010-01-20 17:01             ` Jason Wessel
2010-01-14 14:59 ` [PATCH 21/40] powerpc,kgdb: Introduce low level trap catching Jason Wessel
2010-01-14 14:59 ` [PATCH 22/40] mips,kgdb: kdb low level trap catch and stack trace Jason Wessel
2010-01-14 17:29   ` David Daney
2010-01-14 22:32     ` Jason Wessel
2010-01-14 14:59 ` [PATCH 23/40] kgdb: Add the ability to schedule a breakpoint via a tasklet Jason Wessel
2010-01-14 14:59 ` [PATCH 24/40] kgdboc,kdb: Allow kdb to work on a non open console port Jason Wessel
2010-01-14 14:59 ` [PATCH 25/40] printk,kdb: capture printk() when in kdb shell Jason Wessel
2010-01-14 14:59 ` [PATCH 26/40] keyboard, input: Add hook to input to allow low level event clear Jason Wessel
2010-01-14 14:59 ` [PATCH 27/40] debug_core,kdb: Allow the debug core to process a recursive debug entry Jason Wessel
2010-01-14 14:59 ` [PATCH 28/40] kdb,panic,debug_core: Allow the debug core to receive a panic before smp_send_stop() Jason Wessel
2010-01-14 14:59 ` [PATCH 29/40] MAINTAINERS: update kgdb, kdb, and debug_core info Jason Wessel
2010-01-14 14:59 ` [PATCH 30/40] kgdboc,debug_core: Add call backs to allow kernel mode switching Jason Wessel
2010-01-14 14:59 ` [PATCH 31/40] kgdb: add ops arg to kgdb console active & restore hooks Jason Wessel
2010-01-14 14:59 ` [PATCH 32/40] drm: add KGDB/KDB support Add support for KDB entry/exit Jason Wessel
2010-01-14 14:59 ` [PATCH 33/40] kms,kdb: Force unblank a console device Jason Wessel
2010-01-14 14:59 ` Jason Wessel [this message]
2010-01-14 14:59 ` [PATCH 35/40] drm_fb_helper: Preserve capability to use atomic kms Jason Wessel
2010-01-14 14:59 ` [PATCH 36/40] drm,i915 - atomic mutex hacks Jason Wessel
2010-01-14 14:59 ` [PATCH 37/40] kgdb,docs: Update the kgdb docs to include kms Jason Wessel
2010-01-14 14:59 ` [PATCH 38/40] kgdbts,sh: Add in breakpoint pc offset for superh Jason Wessel
2010-01-14 14:59 ` [PATCH 39/40] debug_core: Turn off tracing while in the debugger Jason Wessel
2010-01-15  0:10   ` Steven Rostedt
2010-01-15 14:03     ` Jason Wessel
2010-01-15 15:04       ` Steven Rostedt
2010-01-14 14:59 ` [PATCH 40/40] ftrace,kdb: Extend kdb to be able to dump the ftrace buffer Jason Wessel
2010-01-15  0:14   ` Steven Rostedt
2010-01-15 13:15     ` Jason Wessel
2010-01-30  2:02 ` [PATCH 0/40] kgdb, kdb and atomic kernel modesetting series Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263481176-1897-35-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=airlied@linux.ie \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®