mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] USB-IP: Small clean up based on previous comments.
@ 2010-01-22 18:20 Himanshu Chauhan
  2010-01-22 18:20 ` Himanshu Chauhan
  0 siblings, 1 reply; 2+ messages in thread
From: Himanshu Chauhan @ 2010-01-22 18:20 UTC (permalink / raw)
  To: Linux Kernel

Hi,

I am trying to take a look at usb-ip to get it into mainline.
This is a small patch (my first patch ever) in this regard.

Please let me know the comments.

Thanks

Regards
Himanshu

Signed-off-by: Himanshu Chauhan <himanshu@symmetricore.com>
---
 drivers/staging/usbip/usbip_common.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index ddb6f5f..57c0ff5 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -55,10 +55,7 @@ static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
 static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
 		const char *buf, size_t count)
 {
-	unsigned long flag;
-
-	sscanf(buf, "%lx", &flag);
-	usbip_debug_flag = flag;
+	sscanf(buf, "%lx", &usbip_debug_flag);
 
 	return count;
 }
-- 
1.6.3.3


^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH] USB-IP: Small clean up based on previous comments.
  2010-01-22 18:20 [PATCH] USB-IP: Small clean up based on previous comments Himanshu Chauhan
@ 2010-01-22 18:20 ` Himanshu Chauhan
  0 siblings, 0 replies; 2+ messages in thread
From: Himanshu Chauhan @ 2010-01-22 18:20 UTC (permalink / raw)
  To: Linux Kernel

Hi,

I am trying to take a look at usb-ip to get it into mainline.
This is a small patch (my first patch ever) in this regard.

Please let me know the comments.

Thanks

Regards
Himanshu

---
 drivers/staging/usbip/usbip_common.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index ddb6f5f..57c0ff5 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -55,10 +55,7 @@ static ssize_t show_flag(struct device *dev, struct device_attribute *attr,
 static ssize_t store_flag(struct device *dev, struct device_attribute *attr,
 		const char *buf, size_t count)
 {
-	unsigned long flag;
-
-	sscanf(buf, "%lx", &flag);
-	usbip_debug_flag = flag;
+	sscanf(buf, "%lx", &usbip_debug_flag);
 
 	return count;
 }
-- 
1.6.3.3


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-22 18:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-22 18:20 [PATCH] USB-IP: Small clean up based on previous comments Himanshu Chauhan
2010-01-22 18:20 ` Himanshu Chauhan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®