mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Darren Hart <dvhltc@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: rostedt@goodmis.org, Darren Hart <dvhltc@us.ibm.com>
Subject: [PATCH 3/3] kernel-shark: fix unitialized handle compile warnings
Date: Mon,  1 Feb 2010 08:50:26 -0800	[thread overview]
Message-ID: <1265043026-24987-4-git-send-email-dvhltc@us.ibm.com> (raw)
In-Reply-To: <1265043026-24987-1-git-send-email-dvhltc@us.ibm.com>

Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
---
 kernel-shark.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel-shark.c b/kernel-shark.c
index 9dedf48..222381c 100644
--- a/kernel-shark.c
+++ b/kernel-shark.c
@@ -596,10 +596,10 @@ void kernel_shark(int argc, char **argv)
 		if (ret >= 0)
 			input_file = default_input_file;
 	}
-	if (handle)
-		handle = tracecmd_open(input_file);
+	handle = tracecmd_open(input_file);
 
-	info->handle = handle;
+	if (handle)
+		info->handle = handle;
 
 	/* --- Main window --- */
 
-- 
1.6.3.3


  parent reply	other threads:[~2010-02-01 16:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 16:50 [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart
2010-02-01 16:50 ` [PATCH 1/3] trace-graph: fix printf compile warnings Darren Hart
2010-02-01 16:50 ` [PATCH 2/3] trace-cmd: " Darren Hart
2010-02-03 16:07   ` John Kacur
2010-02-03 16:31     ` Steven Rostedt
2010-02-03 16:40       ` John Kacur
2010-02-03 17:12       ` Darren Hart
2010-02-03 17:21         ` Steven Rostedt
2010-02-01 16:50 ` Darren Hart [this message]
2010-02-03 16:05   ` [PATCH 3/3] kernel-shark: fix unitialized handle " John Kacur
2010-02-03 16:17     ` Steven Rostedt
2010-02-03 16:19       ` Steven Rostedt
2010-02-03 16:42         ` John Kacur
2010-02-03 16:51           ` Steven Rostedt
2010-02-01 16:59 ` [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265043026-24987-4-git-send-email-dvhltc@us.ibm.com \
    --to=dvhltc@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®