From: Steven Rostedt <rostedt@goodmis.org>
To: Darren Hart <dvhltc@us.ibm.com>
Cc: John Kacur <jkacur@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] trace-cmd: fix printf compile warnings
Date: Wed, 03 Feb 2010 12:21:56 -0500 [thread overview]
Message-ID: <1265217716.24386.9.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4B69AE88.7080705@us.ibm.com>
On Wed, 2010-02-03 at 09:12 -0800, Darren Hart wrote:
> > Of the three patches, I think this is the only one that is correct ;-)
>
> The other appear to depend on the guint arch specific implementation of
> the guint64 type, so the only way to fix it with a cast to ull - or to
> not use g types at all. Bleh.
I'm fixing it up by typecasting it to (u64), and defining it.
I probably should never have used guint64 but since that's the "glib"
thing to do, and when in Rome do as the Romans do, even if the Romans
are doing crap!
-- Steve
next prev parent reply other threads:[~2010-02-03 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 16:50 [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart
2010-02-01 16:50 ` [PATCH 1/3] trace-graph: fix printf compile warnings Darren Hart
2010-02-01 16:50 ` [PATCH 2/3] trace-cmd: " Darren Hart
2010-02-03 16:07 ` John Kacur
2010-02-03 16:31 ` Steven Rostedt
2010-02-03 16:40 ` John Kacur
2010-02-03 17:12 ` Darren Hart
2010-02-03 17:21 ` Steven Rostedt [this message]
2010-02-01 16:50 ` [PATCH 3/3] kernel-shark: fix unitialized handle " Darren Hart
2010-02-03 16:05 ` John Kacur
2010-02-03 16:17 ` Steven Rostedt
2010-02-03 16:19 ` Steven Rostedt
2010-02-03 16:42 ` John Kacur
2010-02-03 16:51 ` Steven Rostedt
2010-02-01 16:59 ` [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265217716.24386.9.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dvhltc@us.ibm.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®