From: John Kacur <jkacur@redhat.com>
To: Darren Hart <dvhltc@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH 2/3] trace-cmd: fix printf compile warnings
Date: Wed, 3 Feb 2010 17:07:24 +0100 [thread overview]
Message-ID: <520f0cf11002030807t48678b82ye56624840e6f9ce3@mail.gmail.com> (raw)
In-Reply-To: <1265043026-24987-3-git-send-email-dvhltc@us.ibm.com>
On Mon, Feb 1, 2010 at 5:50 PM, Darren Hart <dvhltc@us.ibm.com> wrote:
> Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
> ---
> trace-read.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/trace-read.c b/trace-read.c
> index a04c85b..5befaba 100644
> --- a/trace-read.c
> +++ b/trace-read.c
> @@ -216,7 +216,7 @@ static void read_rest(void)
> r = read(input_fd, buf, BUFSIZ);
> if (r > 0) {
> buf[r] = 0;
> - printf(buf);
> + printf("%s", buf);
> }
> } while (r > 0);
> }
> --
> 1.6.3.3
>
Oh! Obviously correct, thanks Darren.
next prev parent reply other threads:[~2010-02-03 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 16:50 [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart
2010-02-01 16:50 ` [PATCH 1/3] trace-graph: fix printf compile warnings Darren Hart
2010-02-01 16:50 ` [PATCH 2/3] trace-cmd: " Darren Hart
2010-02-03 16:07 ` John Kacur [this message]
2010-02-03 16:31 ` Steven Rostedt
2010-02-03 16:40 ` John Kacur
2010-02-03 17:12 ` Darren Hart
2010-02-03 17:21 ` Steven Rostedt
2010-02-01 16:50 ` [PATCH 3/3] kernel-shark: fix unitialized handle " Darren Hart
2010-02-03 16:05 ` John Kacur
2010-02-03 16:17 ` Steven Rostedt
2010-02-03 16:19 ` Steven Rostedt
2010-02-03 16:42 ` John Kacur
2010-02-03 16:51 ` Steven Rostedt
2010-02-01 16:59 ` [PATCH 0/3 V2] trace-cmd: compiler warning fixes Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520f0cf11002030807t48678b82ye56624840e6f9ce3@mail.gmail.com \
--to=jkacur@redhat.com \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®