From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
lizf@cn.fujitsu.com, fweisbec@gmail.com, mingo@elte.hu,
hpa@zytor.com, tglx@linutronix.de, mhiramat@redhat.com
Subject: Re: [PATCH 5/6] syscalls: add define syscall prefix macro
Date: Tue, 09 Feb 2010 22:00:13 -0500 [thread overview]
Message-ID: <1265770813.24386.48.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20100208171113.GD2688@redhat.com>
On Mon, 2010-02-08 at 12:11 -0500, Jason Baron wrote:
> Most of the copat syscall are currently not using the 'SYCALL_DEFINE()'
> family of macros. For my purposes, the use of these macros allows them
> to be tied into the event tracing system. These macros append 'sys_' to
> the begging of the system call name. However, for compat syscall which
> are named 'sys32_blah', these macros are not sufficient. Thus, the need
> to introduce some new macros for the compat syscalls.
>
> > The added level of indirection makes problems for scripts/kernel-doc (well, if any of
> > the syscalls have kernel-doc notation, that is). I'd prefer not to see 2 levels of macros
> > for defining a syscall, but if it has to live, please look into updating scripts/kernel-doc
> > also.
> >
>
> good point. I'll make sure the docs work properly.
Could you also make sure 'make TAGS' is updated too.
See scripts/tags.sh and search for SYSCALL
-- Steve
next prev parent reply other threads:[~2010-02-10 3:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 21:21 [PATCH 0/6] tracing: add compat syscall support Jason Baron
2010-02-02 21:21 ` [PATCH 1/6] x86: add NR_syscalls_compat, make ia32 syscall table visible Jason Baron
2010-02-02 21:21 ` [PATCH 2/6] x86: add arch_compat_syscall_addr() Jason Baron
2010-02-02 21:21 ` [PATCH 3/6] tracing: remove syscall bitmaps in preparation for compat support Jason Baron
2010-02-02 21:21 ` [PATCH 4/6] tracing: add tracing support for compat syscalls Jason Baron
2010-02-03 12:52 ` Heiko Carstens
2010-02-08 15:43 ` Jason Baron
2010-02-08 16:34 ` Heiko Carstens
2010-02-09 10:21 ` Heiko Carstens
2010-02-09 14:54 ` Jason Baron
2010-02-02 21:21 ` [PATCH 5/6] syscalls: add define syscall prefix macro Jason Baron
2010-02-03 13:01 ` Heiko Carstens
2010-02-08 15:48 ` Jason Baron
2010-02-08 16:12 ` Arnd Bergmann
2010-02-08 17:54 ` Christoph Hellwig
2010-02-08 20:48 ` Arnd Bergmann
2010-02-08 16:53 ` Randy Dunlap
2010-02-08 17:11 ` Jason Baron
2010-02-10 3:00 ` Steven Rostedt [this message]
2010-02-02 21:22 ` [PATCH 6/6] x86: convert compat syscalls to use 'DEFINE_SYSCALL()' macros Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265770813.24386.48.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®