* [PATCH 1/1] DVB: ngene, fix memset parameters
@ 2010-02-10 23:32 Jiri Slaby
2010-02-11 4:20 ` Oliver Endriss
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2010-02-10 23:32 UTC (permalink / raw)
To: mchehab
Cc: linux-media, linux-kernel, jirislaby, Matthias Benesch,
Ralph Metzler, Oliver Endriss
Switch second and third memset parameter to stamp the length buffer bytes
by 0xff's, not 255 bytes by low 8 bits of Length.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Matthias Benesch <twoof7@freenet.de>
Cc: Ralph Metzler <rjkm@metzlerbros.de>
Cc: Oliver Endriss <o.endriss@gmx.de>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
---
drivers/media/dvb/ngene/ngene-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
index cb5982e..0150dfe 100644
--- a/drivers/media/dvb/ngene/ngene-core.c
+++ b/drivers/media/dvb/ngene/ngene-core.c
@@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
{
u32 *ptr = Buffer;
- memset(Buffer, Length, 0xff);
+ memset(Buffer, 0xff, Length);
while (Length > 0) {
if (Flags & DF_SWAP32)
*ptr = 0x471FFF10;
--
1.6.6.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] DVB: ngene, fix memset parameters
2010-02-10 23:32 [PATCH 1/1] DVB: ngene, fix memset parameters Jiri Slaby
@ 2010-02-11 4:20 ` Oliver Endriss
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Endriss @ 2010-02-11 4:20 UTC (permalink / raw)
To: Jiri Slaby
Cc: mchehab, linux-media, linux-kernel, jirislaby, Matthias Benesch,
Ralph Metzler
Jiri Slaby wrote:
> Switch second and third memset parameter to stamp the length buffer bytes
> by 0xff's, not 255 bytes by low 8 bits of Length.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Matthias Benesch <twoof7@freenet.de>
> Cc: Ralph Metzler <rjkm@metzlerbros.de>
> Cc: Oliver Endriss <o.endriss@gmx.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> drivers/media/dvb/ngene/ngene-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index cb5982e..0150dfe 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -564,7 +564,7 @@ static void FillTSBuffer(void *Buffer, int Length, u32 Flags)
> {
> u32 *ptr = Buffer;
>
> - memset(Buffer, Length, 0xff);
> + memset(Buffer, 0xff, Length);
> while (Length > 0) {
> if (Flags & DF_SWAP32)
> *ptr = 0x471FFF10;
> --
> 1.6.6.1
Acked-by: Oliver Endriss <o.endriss@gmx.de>
CU
Oliver
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-11 4:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-10 23:32 [PATCH 1/1] DVB: ngene, fix memset parameters Jiri Slaby
2010-02-11 4:20 ` Oliver Endriss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®