[PATCH 2/2] Staging: wlan-ng: fix most of the style issues in hfa384x.h

[PATCH 2/2] Staging: wlan-ng: fix most of the style issues in hfa384x.h

[Alessandro Ghedini]

This patch fixes all the errors and the majority of the warnings found with
checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints

Signed-off-by: Alessandro Ghedini <al3xbio@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x.h |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 8e39f76..3d440f8 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -63,15 +63,9 @@
 /*--- Mins & Maxs -----------------------------------*/
 #define		HFA384x_PORTID_MAX		((u16)7)
 #define		HFA384x_NUMPORTS_MAX		((u16)(HFA384x_PORTID_MAX+1))
-#define		HFA384x_PDR_LEN_MAX		((u16)512) 	/*
-								 * in bytes,
-								 * from EK
-								 */
+#define		HFA384x_PDR_LEN_MAX	((u16)512) 	/* in bytes, from EK */
 #define		HFA384x_PDA_RECS_MAX		((u16)200)	/* a guess */
-#define		HFA384x_PDA_LEN_MAX		((u16)1024)	/*
-								 * in bytes,
-								 * from EK
-								 */
+#define		HFA384x_PDA_LEN_MAX	((u16)1024)	/* in bytes, from EK*/
 #define		HFA384x_SCANRESULT_MAX		((u16)31)
 #define		HFA384x_HSCANRESULT_MAX		((u16)31)
 #define		HFA384x_CHINFORESULT_MAX	((u16)16)
-- 
1.6.6.2

Re: [PATCH 2/2] Staging: wlan-ng: fix most of the style issues in hfa384x.h

[Gábor Stefanik]

You posted the wrong patch - this is only an interdiff.

Also, it might be a good idea to reduce the spacing for all entries,
not just these "overdone" ones, to keep them lined-up nicely.

On Sun, Feb 14, 2010 at 9:12 PM, Alessandro Ghedini <al3xbio@gmail.com> wrote:
> This patch fixes all the errors and the majority of the warnings found with
> checkpatch.pl script in hfa384x.h, following Gábor Stefanik hints
>
> Signed-off-by: Alessandro Ghedini <al3xbio@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 8e39f76..3d440f8 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -63,15 +63,9 @@
>  /*--- Mins & Maxs -----------------------------------*/
>  #define                HFA384x_PORTID_MAX              ((u16)7)
>  #define                HFA384x_NUMPORTS_MAX            ((u16)(HFA384x_PORTID_MAX+1))
> -#define                HFA384x_PDR_LEN_MAX             ((u16)512)      /*
> -                                                                * in bytes,
> -                                                                * from EK
> -                                                                */
> +#define                HFA384x_PDR_LEN_MAX     ((u16)512)      /* in bytes, from EK */
>  #define                HFA384x_PDA_RECS_MAX            ((u16)200)      /* a guess */
> -#define                HFA384x_PDA_LEN_MAX             ((u16)1024)     /*
> -                                                                * in bytes,
> -                                                                * from EK
> -                                                                */
> +#define                HFA384x_PDA_LEN_MAX     ((u16)1024)     /* in bytes, from EK*/
>  #define                HFA384x_SCANRESULT_MAX          ((u16)31)
>  #define                HFA384x_HSCANRESULT_MAX         ((u16)31)
>  #define                HFA384x_CHINFORESULT_MAX        ((u16)16)
> --
> 1.6.6.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)